Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bluss/arrayvec
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: bluss/arrayvec
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.4
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Oct 9, 2019

  1. FIX: Replace uses of <[T]>::get_unchecked_mut with raw pointer accessor 

    This is a soundness fix w.r.t unsafe coding guidelines.

In some of the instances, `get_unchecked_mut() -> &mut T as *mut T` was
used in places where the element was potentially uninitialized.

This was a problem in push. (Not a problem in IntoIter next/next_back,
where the whole range we're iterating is initialized).

(Backported fix to 0.4 from the master/0.5 branch)
    @bluss
    bluss committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    91a7f7a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #139 from bluss/uninit-soundness-0.4 

    Replace uses of <[T]>::get_unchecked_mut with raw pointer accessor (0.4 branch)
    @bluss
    bluss authored Oct 9, 2019
    Configuration menu
    Copy the full SHA
    79e0908 View commit details
    Browse the repository at this point in the history

  3. 0.4.12

    @bluss
    bluss committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    f88c62e View commit details
    Browse the repository at this point in the history
Loading