From eac653d9cbbe4de0292063260067bb5b3075aaf3 Mon Sep 17 00:00:00 2001 From: Scott Cook Date: Wed, 6 Oct 2021 14:35:09 -0700 Subject: [PATCH 1/6] Fixed typo in test output --- exercises/concept/poetry-club-door-policy/door-policy.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/concept/poetry-club-door-policy/door-policy.spec.js b/exercises/concept/poetry-club-door-policy/door-policy.spec.js index 624aa84135..e112bf91b3 100644 --- a/exercises/concept/poetry-club-door-policy/door-policy.spec.js +++ b/exercises/concept/poetry-club-door-policy/door-policy.spec.js @@ -117,7 +117,7 @@ describe('back door response', () => { expect(actualLetters).toStrictEqual(expectedLetters); }); - test('should igniore whitespace when taking the last letter character of each line of SHIRE_HORSE_WITH_SPACES', () => { + test('should ignore whitespace when taking the last letter character of each line of SHIRE_HORSE_WITH_SPACES', () => { const actualLetters = recite(SHIRE_HORSE_WITH_SPACES, backDoorResponse); const expectedLetters = ['h', 'o', 'r', 's', 'e']; expect(actualLetters).toStrictEqual(expectedLetters); From a0f33dfad1ddf48df1662f3ec04474778c954531 Mon Sep 17 00:00:00 2001 From: Scott Cook Date: Fri, 15 Oct 2021 11:45:34 -0700 Subject: [PATCH 2/6] Fixed broken link. Concept page 'class' non-existent --- concepts/objects/about.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/concepts/objects/about.md b/concepts/objects/about.md index 35c52fd438..d55f559add 100644 --- a/concepts/objects/about.md +++ b/concepts/objects/about.md @@ -12,7 +12,7 @@ The values inside one object can have different types. They can be primitive types like numbers but also arrays, other objects or even functions. This makes objects very versatile so that they are also key entities for [object-oriented programming][oop] (OOP) in JavaScript. -In the following we will focus on objects as collections or maps. Other use cases of objects will be covered in other concepts, see e.g., [Classes][concept-classes]. +In the following we will focus on objects as collections or maps. Other use cases of objects will be covered in other concepts, see e.g., [Classes][classes]. ## Creating an Object @@ -259,7 +259,7 @@ For example, it contains the `hasOwnProperty` method and other methods like `toS Usually that does not cause any problems but if you ever need to create a truly empty object use a [null object][mdn-null-object] that can be created via `Object.create(null)`. [oop]: https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Object-oriented_JS -[concept-classes]: /tracks/javascript/concepts/classes +[classes]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes [literal]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Grammar_and_types#literals [mdn-trailing-commas]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas [mdn-identifier]: https://developer.mozilla.org/en-US/docs/Glossary/Identifier From fd5960a6c4b35a520e86e8ef07cbaa7a0e38aea0 Mon Sep 17 00:00:00 2001 From: Scott Cook Date: Fri, 15 Oct 2021 12:16:50 -0700 Subject: [PATCH 3/6] Updated broken concepts inheritance link --- concepts/objects/introduction.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/concepts/objects/introduction.md b/concepts/objects/introduction.md index a878704b9d..6b0e79ef8f 100644 --- a/concepts/objects/introduction.md +++ b/concepts/objects/introduction.md @@ -141,9 +141,9 @@ for (let key in obj) { ``` To avoid subtle errors you should always assume the `for...in` loop visits the keys in an arbitrary order. -Also be aware that `for...in` includes [inherited keys][concept-inheritance] in its iteration. +Also be aware that `for...in` includes [inherited keys][mdn-inheritance] in its iteration. [oop]: https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Object-oriented_JS [concept-classes]: /tracks/javascript/concepts/classes [mdn-identifier]: https://developer.mozilla.org/en-US/docs/Glossary/Identifier -[concept-inheritance]: /tracks/javascript/concepts/inheritance +[mdn-inheritance]: https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Inheritance From e83e2d8afb075379ad34e894187eb546ffb4c3b8 Mon Sep 17 00:00:00 2001 From: Scott Cook Date: Tue, 26 Oct 2021 11:11:43 -0700 Subject: [PATCH 4/6] Fixed typo --- exercises/concept/lucky-numbers/.docs/introduction.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/concept/lucky-numbers/.docs/introduction.md b/exercises/concept/lucky-numbers/.docs/introduction.md index 3b4faaceda..abcf29b5db 100644 --- a/exercises/concept/lucky-numbers/.docs/introduction.md +++ b/exercises/concept/lucky-numbers/.docs/introduction.md @@ -31,7 +31,7 @@ Boolean(''); // => false ``` -Note that because of the described rules, `'0'`, `'false'`, `[]` and `{}` are **thruthy** in JavaScript. +Note that because of the described rules, `'0'`, `'false'`, `[]` and `{}` are **truthy** in JavaScript. ### Converting to a Number From 454371d5b0485466a644154a8b2cb8ec91475d3c Mon Sep 17 00:00:00 2001 From: Scott Cook Date: Sat, 30 Oct 2021 09:52:24 -0700 Subject: [PATCH 5/6] Fixed typo in type conversion docs --- concepts/type-conversion/about.md | 2 +- concepts/type-conversion/introduction.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/concepts/type-conversion/about.md b/concepts/type-conversion/about.md index 8b6bfa9239..827149b19f 100644 --- a/concepts/type-conversion/about.md +++ b/concepts/type-conversion/about.md @@ -34,7 +34,7 @@ Boolean(''); // => false ``` -Note that because of the described rules, `'0'`, `'false'`, `[]` and `{}` are **thruthy** in JavaScript. +Note that because of the described rules, `'0'`, `'false'`, `[]` and `{}` are **truthy** in JavaScript. ### Converting to a Number diff --git a/concepts/type-conversion/introduction.md b/concepts/type-conversion/introduction.md index 3b4faaceda..abcf29b5db 100644 --- a/concepts/type-conversion/introduction.md +++ b/concepts/type-conversion/introduction.md @@ -31,7 +31,7 @@ Boolean(''); // => false ``` -Note that because of the described rules, `'0'`, `'false'`, `[]` and `{}` are **thruthy** in JavaScript. +Note that because of the described rules, `'0'`, `'false'`, `[]` and `{}` are **truthy** in JavaScript. ### Converting to a Number From 9e22559ae74075bb789a16527a0616ceb65d531c Mon Sep 17 00:00:00 2001 From: Scott Cook Date: Sat, 30 Oct 2021 10:00:50 -0700 Subject: [PATCH 6/6] Updated with upstream/main --- concepts/objects/introduction.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/concepts/objects/introduction.md b/concepts/objects/introduction.md index 6b0e79ef8f..a878704b9d 100644 --- a/concepts/objects/introduction.md +++ b/concepts/objects/introduction.md @@ -141,9 +141,9 @@ for (let key in obj) { ``` To avoid subtle errors you should always assume the `for...in` loop visits the keys in an arbitrary order. -Also be aware that `for...in` includes [inherited keys][mdn-inheritance] in its iteration. +Also be aware that `for...in` includes [inherited keys][concept-inheritance] in its iteration. [oop]: https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Object-oriented_JS [concept-classes]: /tracks/javascript/concepts/classes [mdn-identifier]: https://developer.mozilla.org/en-US/docs/Glossary/Identifier -[mdn-inheritance]: https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Inheritance +[concept-inheritance]: /tracks/javascript/concepts/inheritance