codeql/javascript/ql/test/query-tests/React/InconsistentStateUpdate/tst.js at codeql-cli-2.26.3 · github/codeql · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
class C1 extends React.Component {
  upd8() {
    this.setState({
      counter: this.state.counter + 1 // OK - ignored because it is safe in practice
    });
  }
}

class C2 extends React.Component {
  upd8() {
    this.setState((prevState) => {
      counter: prevState.counter + 1
    });
  }
}

class C3 extends React.Component {
  upd8() {
    var app = this;
    app.setState({
      counter: this.state.counter + 1 // OK - ignored because it is safe in practice
    });
  }
}

class C4 extends React.Component {
  upd8() {
    this.setState({
      counter: this.state.foo
    }); // $ Alert
  }
}

class C5 extends React.Component {
  upd8() {
    this.setState({
        foo: { bar: this.state.foo.bar }
    }); // $ Alert
  }
}

class C7 extends React.Component {
    upd8a() {
        this.setState({
            foo: this.state.foo
        }); // $ Alert
    }

    upd8b() {
        this.setState({
            foo: this.state.foo
        }); // $ Alert
    }
}

class C8 extends React.Component {
    upd8a() {
        this.setState({
            foo: this.state.foo + 1
        }); // $ Alert
    }

    upd8b() {
        this.setState({
            foo: this.state.foo + 1
        }); // $ Alert
    }
}

class C9 extends React.Component {
    upd8a() {
        this.setState({
            foo: { bar: this.state.foo.bar }
        }); // $ Alert
    }

    upd8b() {
        this.setState({
            foo: { bar: this.state.foo.bar }
        }); // $ Alert
    }
}

class C10 extends React.Component {
    upd8a() {
        this.setState({
            foo: this.state.foo,
            bar: this.state.bar // OK - ignored because it is safe in practice
        }); // $ Alert
    }

    upd8b() {
        this.setState({
            foo: this.state.foo
        }); // $ Alert
    }
}

class C11 extends React.Component {
    upd8a() {
        var self = this;
        self.setState({
            foo: self.state.foo
        }); // $ Alert
    }

    upd8b() {
        this.setState({
            foo: this.state.foo
        }); // $ Alert
    }
}