Skip to content

Commit 4e2c9f3

Browse files
gmondelloclaude
andcommitted
Apply docs style feedback: hyphenate placeholders, remove duplicate link
- Use hyphenated placeholders (YOUR-CONNECTION-ID, YOUR-DOCKER-ORG) per docs style, while leaving the DOCKERHUB_OIDC_CONNECTIONID env var name untouched since it's a literal required identifier, not a placeholder - Remove the "Further reading" section, which duplicated the AUTOTITLE link already given in the Subject claim matching note Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent dcaf739 commit 4e2c9f3

1 file changed

Lines changed: 6 additions & 10 deletions

File tree

  • content/actions/how-tos/secure-your-work/security-harden-deployments

content/actions/how-tos/secure-your-work/security-harden-deployments/oidc-in-docker.md

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ To use OIDC with Docker, establish a trust relationship between {% data variable
4949

5050
Once you have created an OIDC connection in Docker, update your workflow to authenticate using the [`docker/login-action`](https://github.com/docker/login-action) action.
5151

52-
The following example uses the placeholder `YOUR_CONNECTION_ID` for the connection ID you copied from Docker, and `YOUR_DOCKER_ORG` for your Docker organization name.
52+
The following example uses the placeholder `YOUR-CONNECTION-ID` for the connection ID you copied from Docker, and `YOUR-DOCKER-ORG` for your Docker organization name.
5353

5454
```yaml
5555
{% data reusables.actions.actions-not-certified-by-github-comment %}
@@ -67,15 +67,15 @@ jobs:
6767
- name: Sign in to Docker Hub with OIDC
6868
uses: docker/login-action@abd2ef45e78c5afb21d64d4ca52ee8550d9572c7 # v4.5.1
6969
with:
70-
username: YOUR_DOCKER_ORG
70+
username: YOUR-DOCKER-ORG
7171
env:
72-
DOCKERHUB_OIDC_CONNECTIONID: YOUR_CONNECTION_ID
72+
DOCKERHUB_OIDC_CONNECTIONID: YOUR-CONNECTION-ID
7373

7474
- name: Build and push
7575
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6
7676
with:
7777
push: true
78-
tags: YOUR_DOCKER_ORG/my-image:latest
78+
tags: YOUR-DOCKER-ORG/my-image:latest
7979
```
8080
8181
### Key workflow settings
@@ -102,12 +102,12 @@ jobs:
102102
id: docker-oidc
103103
uses: docker/oidc-action@3f002d200df5620744c973221788e401898c6f86 # v1
104104
with:
105-
connection_id: YOUR_CONNECTION_ID
105+
connection_id: YOUR-CONNECTION-ID
106106
107107
- name: Sign in to Docker Hub
108108
uses: docker/login-action@abd2ef45e78c5afb21d64d4ca52ee8550d9572c7 # v4.5.1
109109
with:
110-
username: YOUR_DOCKER_ORG
110+
username: YOUR-DOCKER-ORG
111111
password: {% raw %}${{ steps.docker-oidc.outputs.token }}{% endraw %}
112112
```
113113

@@ -134,7 +134,3 @@ Different workflow triggers produce different subject claims. For example:
134134
You can use wildcard patterns in your rulesets to match multiple repositories or branches. For example, `repo:my-org/*` matches all repositories in your organization.
135135

136136
For more information, see [Rulesets and subject claims](https://docs.docker.com/enterprise/security/oidc-connections/rulesets-claims/) in the Docker documentation.
137-
138-
## Further reading
139-
140-
* [AUTOTITLE](/actions/concepts/security/openid-connect)

0 commit comments

Comments
 (0)