Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ionic-team/ionic-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @ionic/cli-framework@1.0.4
Choose a base ref
...
head repository: ionic-team/ionic-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @ionic/cli-framework@1.0.5
Choose a head ref
  • 3 commits
  • 46 files changed
  • 2 contributors

Commits on Aug 9, 2018

  1. fix(serve): fix unclosed connection issue again (#3500) 

    Keeping BottomBar open seems to be a consistent issue on Windows.
BottomBar creates a readline interface, so SIGINT has to go through it,
and the signal doesn't seem to bubble up properly, which means the Ionic
CLI cannot properly clean up resources during a Ctrl-C, leading to serve
issues where the underlying CLI is not terminated.
    @imhoffd
    imhoffd authored Aug 9, 2018
    Configuration menu
    Copy the full SHA
    1f0ef3b View commit details
    Browse the repository at this point in the history

  2. fix(serve): use configured host for v1 serve 

    Fixes #3496
    @imhoffd
    imhoffd committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    211906a View commit details
    Browse the repository at this point in the history

  3. chore(release): publish [skip ci] 

     - @ionic/cli-framework@1.0.5
 - @ionic/cli-utils@2.0.6
 - @ionic/lab@1.0.6
 - @ionic/ng-toolkit@1.0.6
 - @ionic/v1-toolkit@1.0.5
 - cli-scripts@0.0.15
 - ionic@4.0.6
    @Ionitron
    Ionitron committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    79b1a14 View commit details
    Browse the repository at this point in the history
Loading