Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 188ed074a96f341a18f057c535f8e0ba781fdc6d
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fb58cae1e2d5685751f2ed9c32fddfd60ecb2aeb
Choose a head ref
  • 7 commits
  • 12 files changed
  • 1 contributor

Commits on Apr 19, 2018

  1. src: add THROW_ERR_* helpers 

    PR-URL: #20121
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @joyeecheung
    joyeecheung committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    0f16528 View commit details
    Browse the repository at this point in the history

  2. src: migrate ERR_INDEX_OUT_OF_RANGE in C++ 

    This patch migrates the "Index out of range" errors in C++
to errors with the code `ERR_INDEX_OUT_OF_RANGE` which have
equivalents in JavaScript.

PR-URL: #20121
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @joyeecheung
    joyeecheung committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    7e269f5 View commit details
    Browse the repository at this point in the history

  3. src: throw ERR_INVALID_ARG_TYPE in C++ argument checks 

    - Moves THROW_AND_RETURN_IF_NOT_BUFFER and
  THROW_AND_RETURN_IF_NOT_STRING from node_crypto.cc to
  node_errors.h so it can be reused.
- Move THROW_AND_RETURN_UNLESS_BUFFER in util.h to
  node_buffer.cc and call THROW_AND_RETURN_IF_NOT_BUFFER
  there. The only other reference to THROW_AND_RETURN_UNLESS_BUFFER in
  node_i18n.cc can be safely replaced by an assertion since
  the argument will be checked in JS land.
- Migrate ERR_INVALID_ARG_TYPE errors in C++. We can move the
  checks to JS land if possible later without having to
  go semver-major.

PR-URL: #20121
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @joyeecheung
    joyeecheung committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    2c23e31 View commit details
    Browse the repository at this point in the history

  4. src: throw ERR_BUFFER_OUT_OF_BOUNDS in node_buffer.cc 

    PR-URL: #20121
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @joyeecheung
    joyeecheung committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    8b1b36b View commit details
    Browse the repository at this point in the history

  5. src: throw ERR_MISSING_MODULE in module_wrap.cc 

    PR-URL: #20121
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @joyeecheung
    joyeecheung committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    02dc307 View commit details
    Browse the repository at this point in the history

  6. src: throw ERR_INVALID_ARG_VALUE in node_crypto.cc 

    PR-URL: #20121
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @joyeecheung
    joyeecheung committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    a82902f View commit details
    Browse the repository at this point in the history

  7. src: throw ERR_MISSING_ARGS in node_crypto.cc 

    PR-URL: #20121
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @joyeecheung
    joyeecheung committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    fb58cae View commit details
    Browse the repository at this point in the history
Loading