🐛 aiida: suffix repeated input names

Engine-written files reuse one input name per stage
with different defaults; keep the first, suffix the rest.

Author: GeigerJ2

src/python_workflow_definition/aiida.py

@@ -261,10 +261,19 @@ def _emit_level(
     """Emit wrapper tasks, nested graphs, and one ``@graph`` definition."""
     inputs: dict[int, str] = {}
     params: list[str] = []
+    taken: set[str] = set()
     for node_id in sorted(nodes):
         node: dict[str, t.Any] = nodes[node_id]
         if node["type"] == "input":
             param: str = _identifier(node["name"], what="Input")
+            # Distinct nodes may share a name with different defaults.
+            # Keep the first name, suffix later ones deterministically.
+            base: str = param
+            counter: int = 2
+            while param in taken:
+                param = base + "_" + str(counter)
+                counter += 1
+            taken.add(param)
             inputs[node_id] = param
             params.append(param + "=" + repr(node["value"]))
     _emit_wrappers(lines, nodes, edges, prefix=prefix)

tests/test_aiida.py

@@ -75,6 +75,53 @@ def test_workflow_node_rejected(self):
             with self.assertRaisesRegex(ValidationError, "workflow"):
                 load_workflow_json(nested_file, module_name="pwd_test_nested")
 
+    def test_duplicate_input_names_suffixed(self):
+        duplicate = {
+            "version": "0.1.0",
+            "nodes": [
+                {"id": 0, "type": "input", "name": "x", "value": 1},
+                {"id": 1, "type": "input", "name": "x", "value": 2},
+                {
+                    "id": 2,
+                    "type": "function",
+                    "value": "python_workflow_definition.shared.get_dict",
+                },
+                {"id": 3, "type": "output", "name": "result"},
+            ],
+            "edges": [
+                {
+                    "target": 2,
+                    "targetPort": "a",
+                    "source": 0,
+                    "sourcePort": None,
+                },
+                {
+                    "target": 2,
+                    "targetPort": "b",
+                    "source": 1,
+                    "sourcePort": None,
+                },
+                {
+                    "target": 3,
+                    "targetPort": None,
+                    "source": 2,
+                    "sourcePort": None,
+                },
+            ],
+        }
+        with tempfile.TemporaryDirectory() as tmp:
+            duplicate_file = Path(tmp) / "duplicate.json"
+            duplicate_file.write_text(json.dumps(duplicate))
+            tasks = (
+                load_workflow_json(duplicate_file, module_name="pwd_test_dup")
+                .build()
+                .to_dict()["tasks"]
+            )
+            self.assertEqual(
+                sorted(task["name"] for task in tasks),
+                ["pwd_task_2"],
+            )
+
 
 if __name__ == "__main__":
     unittest.main()