Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: parsechina/engine.io-client-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: socketio/engine.io-client-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 28 files changed
  • 5 contributors

Commits on Dec 8, 2020

  1. ci: migrate to GitHub Actions

    Due to the recent changes to the Travis CI platform (see [1]), we will
    now use GitHub Actions to run the tests.
    
    Note: the certificate was updated because it failed with newer Node.js versions
    
    ```
    _tls_common.js:129
          c.context.setCert(cert);
                    ^
    
    Error: error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee key too small
        at Object.createSecureContext (_tls_common.js:129:17)
        at Server.setSecureContext (_tls_wrap.js:1328:27)
    ```
    
    Reference: https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-java-with-maven
    
    [1]: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
    darrachequesne committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    9a7176b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5c65197 View commit details
    Browse the repository at this point in the history
  3. fix: handle responses without content type (socketio#101)

    This fixes NullPointerException when response doesn't have content type. Exception stack trace:
    
    ```
    java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String okhttp3.MediaType.toString()' on a null object reference
            at io.socket.engineio.client.transports.PollingXHR$Request.onLoad(PollingXHR.java:271)
            at io.socket.engineio.client.transports.PollingXHR$Request.access$700(PollingXHR.java:148)
            at io.socket.engineio.client.transports.PollingXHR$Request$1.onResponse(PollingXHR.java:232)
            at okhttp3.RealCall$AsyncCall.execute(RealCall.java:141)
            at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
            at java.lang.Thread.run(Thread.java:764)
    ```
    Jacek Mleczek authored and darrachequesne committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    6f065b7 View commit details
    Browse the repository at this point in the history
  4. ci: add java 7 in the test matrix

    It was already present in the Travis test matrix.
    darrachequesne committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    180db95 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. chore: bump OkHttp client version

    Versions above 3.12.x have dropped support for Java 7.
    
    Related: https://square.github.io/okhttp/changelog_3x/#version-3130
    darrachequesne committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    8016a5d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b3cc94 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    475f89a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1b7002 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Configuration menu
    Copy the full SHA
    41f89a3 View commit details
    Browse the repository at this point in the history
  2. feat: add an extraHeaders option

    Similar to the option of the JS client:
    
    ```java
    opts = new Socket.Options();
    opts.extraHeaders = singletonMap("authorization", singletonList("bearer abcd"));
    socket = new Socket(opts);
    ```
    
    Note: the refactor of the options (similar to [1]) will be done in a
    future step.
    
    [1] socketio/engine.io-client@5f47a50
    darrachequesne committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    dfe65e3 View commit details
    Browse the repository at this point in the history
  3. fix: check the type of the initial packet

    Before this fix, the client could mark the polling transport as open
    even though the handshake packet was not received properly (for
    example, after a parsing error).
    
    See also: socketio/engine.io-client@1c8cba8
    darrachequesne committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    2b5dfb9 View commit details
    Browse the repository at this point in the history
  4. docs: update website

    darrachequesne committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    cbd341c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    62f1384 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    686ac08 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. feat: create heartbeat scheduler with named threads and as daemon (so…

    …cketio#106)
    
    Co-authored-by: Pavel Valodzka <pavel@valodzka.name>
    valodzka and Pavel Valodzka authored Jan 22, 2021
    Configuration menu
    Copy the full SHA
    7c9c382 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. chore: bump engine.io from 4.0.5 to 4.1.2 in /src/test/resources (soc…

    …ketio#110)
    
    Bumps [engine.io](https://github.com/socketio/engine.io) from 4.0.5 to 4.1.2.
    - [Release notes](https://github.com/socketio/engine.io/releases)
    - [Changelog](https://github.com/socketio/engine.io/blob/4.1.2/CHANGELOG.md)
    - [Commits](socketio/engine.io@4.0.5...4.1.2)
    
    ---
    updated-dependencies:
    - dependency-name: engine.io
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    9be533f View commit details
    Browse the repository at this point in the history
Loading