Add guard against NPE#37
Merged
AndroidDeveloperLB merged 1 commit intoAndroidDeveloperLB:masterfrom May 15, 2018
Merged
Conversation
It is possible that `GetDirectBufferAddress` returns null in some cases. Given this it would be best to guard against attempting to access the `_storedBitmapPixels` variable on a null pointer.
Owner
|
I think you are correct:
|
Owner
|
Please also check if there are similar cases that I didn't protect against. |
Contributor
Author
|
I'm chasing another crash, perhaps it is related. Hopefully I track it down. |
Owner
|
Thank you for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible that
GetDirectBufferAddressreturns null in some cases. Given this it would be best to guard against attempting to access the_storedBitmapPixelsvariable on a null pointer.I could only trigger this issue in a kinda race condition in my application, when I would switch to a new view while an Async task was operating on JniBitmaps. I think this caused the underlying memory to be cleaned up by the system and it would then crash when trying to get the bitmap next.
As far as I can tell this guards against that issue, it no longer crashes for me. However it has been a while since I've done any C++. So let me know if anything needs changing.