Skip to content

Draft Config Refactor - #320

Merged
David Gamero (davidgamero) merged 23 commits into
Azure:mainfrom
meecethereese:draft-config-refactor
Jun 24, 2024
Merged

Draft Config Refactor#320
David Gamero (davidgamero) merged 23 commits into
Azure:mainfrom
meecethereese:draft-config-refactor

Conversation

@meecethereese

@meecethereese Mauricio Ferrari (meecethereese) commented Jun 19, 2024

Copy link
Copy Markdown

Description

At the core of this PR are the changes made to the DraftConfig{} struct. The BuilderVarDefault{} struct was absorbed into BuilderVar{}. This led to a restructuring of all draft.yaml templates as well as a refactoring of several functions to incorporate the new data structure.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Comment thread pkg/config/draftconfig.go Outdated
Comment thread pkg/config/draftconfig.go Outdated

@OliverMKing Oliver King (OliverMKing) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes! They clean things up significantly.

We should split this up to two separate PRs. One for the config refactor and one for the private cluster support

@Vidya2606 Vidya Reddy (Vidya2606) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes, tested them locally and everything looks good.

Comment thread cmd/create.go Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@davidgamero

Copy link
Copy Markdown
Collaborator

just some test issues with unsubstituted variable for {{CHARTOVERRIDES}}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants