Draft Config Refactor - #320
Merged
David Gamero (davidgamero) merged 23 commits intoJun 24, 2024
Merged
Conversation
Oliver King (OliverMKing)
left a comment
Contributor
There was a problem hiding this comment.
I like these changes! They clean things up significantly.
We should split this up to two separate PRs. One for the config refactor and one for the private cluster support
added 10 commits
June 20, 2024 12:09
Tommy Barnes (tbarnes94)
approved these changes
Jun 22, 2024
Vidya Reddy (Vidya2606)
left a comment
Contributor
There was a problem hiding this comment.
I like these changes, tested them locally and everything looks good.
David Gamero (davidgamero)
approved these changes
Jun 24, 2024
David Gamero (davidgamero)
left a comment
Collaborator
There was a problem hiding this comment.
looks good
Collaborator
|
just some test issues with unsubstituted variable for |
David Gamero (davidgamero)
approved these changes
Jun 24, 2024
David Gamero (davidgamero)
left a comment
Collaborator
There was a problem hiding this comment.
lgtm
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At the core of this PR are the changes made to the DraftConfig{} struct. The BuilderVarDefault{} struct was absorbed into BuilderVar{}. This led to a restructuring of all draft.yaml templates as well as a refactoring of several functions to incorporate the new data structure.
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: