Skip to content

Adding IsHelm helper function - #335

Merged
Tommy Barnes (tbarnes94) merged 1 commit into
mainfrom
mchinta/helmsetup
Jul 18, 2024
Merged

Tommy Barnes (tbarnes94) merged 1 commit into
mainfrom
mchinta/helmsetup

Conversation

@manasachi

@manasachi Manasa Chinta (manasachi) commented Jul 18, 2024 •

Copy link
Copy Markdown
Contributor

Description

  • Adding IsHelm() helper function which returns true a directory/file contains a Chart.yaml file. Does not validate the Chart.yaml itself, just checks to see it exists.
  • Moved IsKustomize() to preprocessing_helpers.go as well to reduce clutter in preprocessing/ preprocessing_test.go.
  • Added a test folder which for a test case which should return false for a dir without Chart.yaml

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added Unit tests

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tbarnes94
Tommy Barnes (tbarnes94) enabled auto-merge (squash) July 18, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants