Adding CLI flags for user defined Helm release name and release namespace for rendering helm projects - #352
Merged
Tommy Barnes (tbarnes94) merged 15 commits intoJul 31, 2024
Conversation
Co-authored-by: Tommy Barnes <thomas.jonathan.barnes@gmail.com>
Tommy Barnes (tbarnes94)
requested review from
Nick Keller (NickKeller) and
Manasa Chinta (manasachi)
July 29, 2024 20:34
Manasa Chinta (manasachi)
requested changes
Jul 30, 2024
added 8 commits
July 30, 2024 19:24
Nick Keller (NickKeller)
approved these changes
Jul 31, 2024
Swooo (ShantingLiu)
approved these changes
Jul 31, 2024
Manasa Chinta (manasachi)
approved these changes
Jul 31, 2024
Manasa Chinta (manasachi)
left a comment
Contributor
There was a problem hiding this comment.
great changes!
Manasa Chinta (manasachi)
added a commit
that referenced
this pull request
Jul 31, 2024
…pace for rendering helm projects (#352) Co-authored-by: manasachi <144361666+manasachi@users.noreply.github.com> Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
sallasindhuja
pushed a commit
that referenced
this pull request
Aug 22, 2024
…pace for rendering helm projects (#352) Co-authored-by: manasachi <144361666+manasachi@users.noreply.github.com> Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Manasa Chinta (manasachi)
added a commit
that referenced
this pull request
Oct 7, 2024
…pace for rendering helm projects (#352) Co-authored-by: manasachi <144361666+manasachi@users.noreply.github.com> Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Manasa Chinta (manasachi)
added a commit
that referenced
this pull request
Oct 7, 2024
…pace for rendering helm projects (#352) Co-authored-by: manasachi <144361666+manasachi@users.noreply.github.com> Co-authored-by: Brandon Foley <brandonfoley13@gmail.com> Signed-off-by: Manasa Chinta <manasachinta7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: