Skip to content

migrate createRole assignment to Az SDK - #388

Merged
David Gamero (davidgamero) merged 3 commits into
Azure:mainfrom
Vidya2606:migrateProviderPackage
Oct 24, 2024
Merged

migrate createRole assignment to Az SDK#388
David Gamero (davidgamero) merged 3 commits into
Azure:mainfrom
Vidya2606:migrateProviderPackage

Conversation

@Vidya2606

Copy link
Copy Markdown
Contributor

Description

Migrating create role assignment from Az CLI to Az SDK

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Comment thread pkg/providers/azure.go
Comment thread pkg/providers/az-client.go Outdated
Comment thread pkg/providers/az-client.go Outdated
Comment thread pkg/providers/azure.go

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a minor suggestion. Thank you Vidya Reddy (@Vidya2606)

@davidgamero

Copy link
Copy Markdown
Collaborator

Running a credential test on a local build of this branch, then I'll approve

Comment thread pkg/providers/az-client.go Outdated
@davidgamero

Copy link
Copy Markdown
Collaborator

lgtm. I was able to run the build without encountering the PrincipalNotFound error from before

@Vidya2606
Vidya Reddy (Vidya2606) force-pushed the migrateProviderPackage branch 4 times, most recently from 28f97b4 to a02cabd Compare October 23, 2024 21:52

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants