migrate createRole assignment to Az SDK - #388
Merged
David Gamero (davidgamero) merged 3 commits intoOct 24, 2024
Merged
Conversation
Tatsat (Tats) Mishra 🐉 (Tatsinnit)
approved these changes
Sep 26, 2024
Tatsat (Tats) Mishra 🐉 (Tatsinnit)
requested review from
a team,
Brandon Foley (bfoley13) and
David Gamero (davidgamero)
September 26, 2024 20:54
Tatsat (Tats) Mishra 🐉 (Tatsinnit)
approved these changes
Sep 30, 2024
Hariharan Subramanian (hsubramanianaks)
approved these changes
Oct 1, 2024
Hariharan Subramanian (hsubramanianaks)
left a comment
Contributor
There was a problem hiding this comment.
lgtm, just a minor suggestion. Thank you Vidya Reddy (@Vidya2606)
Collaborator
|
Running a credential test on a local build of this branch, then I'll approve |
Collaborator
|
lgtm. I was able to run the build without encountering the PrincipalNotFound error from before |
David Gamero (davidgamero)
approved these changes
Oct 16, 2024
Vidya Reddy (Vidya2606)
force-pushed
the
migrateProviderPackage
branch
4 times, most recently
from
October 23, 2024 21:52
28f97b4 to
a02cabd
Compare
Vidya Reddy (Vidya2606)
force-pushed
the
migrateProviderPackage
branch
from
October 23, 2024 21:55
a02cabd to
135afd0
Compare
Vidya Reddy (Vidya2606)
force-pushed
the
migrateProviderPackage
branch
from
October 23, 2024 23:31
f9bc2d2 to
2b42fb2
Compare
David Gamero (davidgamero)
approved these changes
Oct 24, 2024
David Gamero (davidgamero)
left a comment
Collaborator
There was a problem hiding this comment.
lgtm
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrating create role assignment from Az CLI to Az SDK
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: