Skip to content

Updating templates and moving tests - #428

Merged
Brandon Foley (bfoley13) merged 11 commits into
mainfrom
brfole/template-changes
Nov 21, 2024
Merged

Brandon Foley (bfoley13) merged 11 commits into
mainfrom
brfole/template-changes

Conversation

@bfoley13

@bfoley13 Brandon Foley (bfoley13) commented Nov 18, 2024 •

Copy link
Copy Markdown
Member

Description

Changes include:

  • updating deployment templates with probe type and adding startup probe
  • added imagePullPolicy to deployment templates
  • added workload identity handling to deployments
  • added an optional secret ref to deployments
  • adding allowedValues on DraftConfig BuilderVar
  • added ConditionValue to BuilderVarConditionalReference
  • Moving tests to individual files

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bfoley13
Brandon Foley (bfoley13) marked this pull request as ready for review November 18, 2024 20:13
Comment thread template/deployments/helm/draft.yaml Outdated
Comment thread template/deployments/helm/draft.yaml
Comment thread template/deployments/kustomize/draft.yaml
Comment thread pkg/config/draftconfig.go Outdated
Comment thread pkg/config/draftconfig.go Outdated
Comment thread pkg/config/validators/validators.go Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bfoley13
Brandon Foley (bfoley13) deleted the brfole/template-changes branch November 21, 2024 17:12
Audra Stump (audrastump) pushed a commit to audrastump/draft that referenced this pull request Dec 13, 2024
Audra Stump (audrastump) pushed a commit to audrastump/draft that referenced this pull request Dec 16, 2024
Audra Stump (audrastump) pushed a commit to audrastump/draft that referenced this pull request Dec 19, 2024
Audra Stump (audrastump) pushed a commit to audrastump/draft that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants