update status checks to always run, add deploytype check for manifests - #477
Merged
Jaiveer Katariya (jaiveerk) merged 15 commits intoJan 27, 2025
Conversation
Brandon Foley (bfoley13)
approved these changes
Jan 27, 2025
Jaiveer Katariya (jaiveerk)
approved these changes
Jan 27, 2025
Jaiveer Katariya (jaiveerk)
left a comment
Contributor
There was a problem hiding this comment.
lmao
Member
|
thanks for the PR, changes lgtm! |
Suneha Bose (bosesuneha)
self-requested a review
January 27, 2025 19:53
Suneha Bose (bosesuneha)
approved these changes
Jan 27, 2025
Closed
16 tasks
Suneha Bose (bosesuneha)
pushed a commit
that referenced
this pull request
Jan 28, 2025
Merged
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a case in the matrix fails, the action runner skips the final required step, which is counted as a success and allows merging, defeating the purpose of having it as a PR gate.
updating to explicitly require jobs for each language to allow failure to be clearly reported
using this workaround as this is issue has been reported and is still not resolved actions/runner#2566
also update tests to include manifest type to match deploy folder