Repository navigation
Fix compatibility issue between older clients and newer workers on DT.AzureStorage - #651
Merged
Merged
Conversation
David Justo (davidmrdavid)
approved these changes
Dec 1, 2021
David Justo (davidmrdavid)
left a comment
Contributor
There was a problem hiding this comment.
LGTM with non-blocking nit.
Member
Author
|
Got an internal customer to independently verify this fix as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #650.
The fix is to essentially short-circuit out of de-dupe detection if the Instances table has a record with a null value for ExecutionId. This will be true only for orchestrations that are started with clients on v1.8.4 or earlier (ExecutionId wasn't added until after the orchestration checkpointed once). For newer clients that do add ExecutionId when scheduling an orchestration, de-dupe detection should continue to work as normal - no change in behavior.