[devin-ai-integration]

Description of the Change

Applies conservative Java 21 pattern matching for instanceof in worldwindx.applications.

Changed files:

• src/gov/nasa/worldwindx/applications/dataimporter/DataInstallerApp.java
• src/gov/nasa/worldwindx/applications/glider/GliderImageLayer.java
• src/gov/nasa/worldwindx/applications/sar/SaveTrackDialog.java

Before/after counts for this package scope:

• new Runnable(): 33 → 33
• new ActionListener(): 78 → 78
• new Callable(): 0 → 0
• new MouseListener(): 1 → 1
• new KeyListener(): 0 → 0
• new ChangeListener(): 13 → 13
• new PropertyChangeListener(): 19 → 19
• new WindowListener(): 0 → 0
• instanceof locations: 172 → 172 (4 cast sites modernized)
• Records introduced: 0
• Sealed hierarchies introduced: 0
• Deprecated API removals: 0
• Text block conversions: 0

Verification:

• ant -f release-build.xml under JDK 21: BUILD SUCCESSFUL
• Test result: 435 tests, 0 failures, 0 errors, 7 skipped
• Public/protected API diff check: no added public/protected declarations
• Test files modified: none

Devin session: https://app.devin.ai/sessions/36287b7c637242dba0a6a659737d5402

Devin Review verdict: local verification passed; no automated CI checks are configured on this fork.

Flagged for human review: listener-heavy SAR/dataimporter UI code, including SAR2.java and CloudCeilingPanel.java, was intentionally not converted because the migration plan requires preserving Swing callback/this semantics unless each conversion is obviously safe.

Why Should This Be In Core?

The WorldWindX applications ship with the repository and must continue compiling cleanly under the Java 21 retarget. This PR modernizes a small set of safe cast sites without changing UI event behavior or public API.

Benefits

• Reduces redundant casts in application code.
• Keeps Wave 4 applications isolated from examples.
• Maintains the full JDK 21 release-build test profile.

Potential Drawbacks

• Dense anonymous listener usage remains for future manual review.
• No functional behavior changes are intended.

Applicable Issues

N/A

Requested by: @jakexcosme

---

Devin Review

Status	Commit
⚪ Not started	—

Run Devin Review

💡 Connect your GitHub account to enable automatic code reviews.

[devin-ai-integration]

Original prompt from Jake

#``# Overview

Migrate COG-GTM/WorldWindJava from Java 11 to Java 21 LTS. This is a federal-grade, zero-breakage migration with atomic per-package PRs, full test verification before and after, and a rollup audit document. Use parallel child sessions to accelerate. All PRs target the fork's develop branch.

#``# PHASE 0: Pre-Migration Baseline (Sequential — MUST complete before anything else)

#``#``# Step 0.1: Capture Pre-Migration Baseline Metrics
Before ANY changes, on the develop branch with JDK 11:

`#` File count
find src -name "*.java" | wc -l
`#` Anonymous inner class counts
grep -rn "new Runnable()" --include="*.java" src/ | wc -l
grep -rn "new ActionListener()" --include="*.java" src/ | wc -l
grep -rn "new Callable()" --include="*.java" src/ | wc -l
grep -rn "new MouseListener()" --include="*.java" src/ | wc -l
grep -rn "new KeyListener()" --include="*.java" src/ | wc -l  
grep -rn "new ChangeListener()" --include="*.java" src/ | wc -l
grep -rn "new PropertyChangeListener()" --include="*.java" src/ | wc -l
grep -rn "new WindowListener()" --include="*.java" src/ | wc -l
`#` instanceof pattern-match candidates
grep -rn "instanceof " --include="*.java" src/ | wc -l
`#` Deprecated usage
grep -rn "`@`Deprecated" --include="*.java" src/ | wc -l
grep -rn "new Integer(" --include="*.java" src/ | wc -l
grep -rn "new Double(" --include="*.java" src/ | wc -l
grep -rn "new Float(" --include="*.java" src/ | wc -l
grep -rn "new Long(" --include="*.java" src/ | wc -l
grep -rn "new Boolean(" --include="*.java" src/ | wc -l

Save all counts to a file BASELINE-METRICS.txt at the repo root. This is your "before" snapshot.

#``#``# Step 0.2: Run the existing test suite under JDK 11

ant -f release-build.xml

Record pass/fail counts. This establishes that the test suite is green BEFORE migration.

#``# PHASE 1: Foundational JDK 21 Retarget PR (Sequential — Wave 0)

#``#``# Step 1.1: Create branch devin/java21-foundation
Make these changes ONLY (no code changes):

1. **`release-... (12653 chars truncated...)

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR that start with 'DevinAI' or '@devin'.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring