fix: make chrome extension button respect dashboard theme - #2220
Open
Abhishek-1337 wants to merge 1 commit into
Open
fix: make chrome extension button respect dashboard theme#2220Abhishek-1337 wants to merge 1 commit into
Abhishek-1337 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Add Chrome Extension" button was always rendering with bg-white - so in dark mode it stayed white while the rest of the dashboard went dark, and any dark: overrides weren't doing anything anyway.
Turns out we don't actually use Tailwind's dark: variant here. Theme is toggled via document.body.className = "dark" / "light" and Radix's gray-dark.css just flips the --gray-* CSS variables. bg-white doesn't flip, but bg-gray-1 / text-gray-12 do automatically.
Change:
Tested by toggling light/dark in the dashboard - button now goes from light gray/near-black text to dark gray/off-white text as expected, hover state works in both.
Greptile Summary
This PR updates the shared Chrome extension button background from fixed white to the theme-aware
gray-1color token.Confidence Score: 5/5
The PR appears safe to merge with no actionable issues identified.
The changed utility is supported by the web Tailwind configuration and follows an existing theme-aware styling pattern, with no behavioral, security, or repository-rule violations found.
Important Files Changed
bg-gray-1utility.Reviews (1): Last reviewed commit: "fix: make chrome extension button respec..." | Re-trigger Greptile