Replace annotations with attributes#6476
Replace annotations with attributes#6476Naktibalda merged 1 commit intoCodeception:5.0from TavoNiievez:5.0-attributes
Conversation
Naktibalda
left a comment
There was a problem hiding this comment.
Now we need test for annotations :)
| * @method void execute($callable) | ||
| * @method void expectTo($prediction) | ||
| * @method void expect($prediction) | ||
| * @method void amGoingTo($argumentation) |
There was a problem hiding this comment.
This docblock was autogenerated, generator still doesn't generate any comments with self return type -
Codeception/src/Codeception/Lib/Generator/Actor.php
Lines 93 to 103 in 522c7f0
|
@TavoNiievez thank you! This one is really important to get merged! |
|
Are we dropping support for annotations now? |
| * @group core | ||
| */ | ||
| #[DataProvider('getRelativeDirTestData')] | ||
| #[Group('core')] |
There was a problem hiding this comment.
Codeception DataProvider attribute does not work in Unit tests.
[ArgumentCountError] Too few arguments to function Codeception\Util\PathResolverTest::testGetRelativeDir(), 0 passed in /.../Codeception/vendor/phpunit/phpunit/src/Framework/TestCase.php on line 1545 and exactly 4 expected
#1 /.../Codeception/tests/unit/Codeception/Util/PathResolverTest.php:15
No, we are not dropping, so I agree that some tests with annotation should also be kept |
|
I resolved conflicts, fixed failing tests and merged to 5.0 See 128727f for tests where it was necessary to keep |
|
Thank you @Naktibalda |
|
and d432509 |
No description provided.