Add regex-based enum extraction to fix header parsing#1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Add regex-based enum extraction to fix header parsing#1devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Implement extract_enums_from_headers() function that uses regex patterns
to dynamically find CUDA enum types that pyclibrary.CParser misses.
Changes:
- Add extract_enums_from_headers() function with three regex patterns:
- typedef __device_builtin__ enum X Y; (CUDA-specific)
- typedef enum X Y; (standard enum typedefs)
- enum X {...} Y?; (inline enum declarations)
- Integrate regex extraction into parse_headers() after CParser processing
- Remove manual CUstreamAtomicReductionDataType_enum addition
- Preserve existing hardcoded replacements for backward compatibility
Fixes NVI-3
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes NVI-3
This PR replaces the hardcoded enum handling in
cuda_bindings/setup.pywith dynamic regex pattern matching to find CUDA enum types thatpyclibrary.CParserfails to extract.Changes
extract_enums_from_headers()function with three regex patterns to match:typedef __device_builtin__ enum X Y;(CUDA-specific enum typedefs)typedef enum X Y;(standard enum typedefs)enum X {...} Y?;(inline enum declarations)parse_headers()after CParser processingCUstreamAtomicReductionDataType_enumaddition and associated TODO commentreplacedictionary for backward compatibilityHuman Review Checklist
CUstreamAtomicReductionDataType_enumis now found by the regex extraction (previously required manual addition)found_types(from both CParser and regex) could cause downstream issues[^}]*which won't handle nested braces - verify this is acceptable for CUDA enum definitionsChecklist
Link to Devin run
Requested by: Shawn Azman (shawn@cognition.ai) (@ShawnAzman)