Repository navigation
Fix reading JSON on Python 3.9+ (removed encoding kwarg) - #52
Open
ARYAMANN7279 wants to merge 1 commit into
Open
ARYAMANN7279 wants to merge 1 commit into
ARYAMANN7279 wants to merge 1 commit into
Conversation
json.load and json.loads dropped the 'encoding' argument in Python 3.9, so reading JSON documents raised TypeError. Only pass it when given.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a JSON-serialised document fails on Python 3.9 and later:
JSONUnserializer.from_fileandfrom_stralways passedencoding=tojson.load(s), and Python 3.9 removed that argument. This only passes it when a value is given, so the default path works again and behaviour for older Pythons stays the same.On Python 3.14 with sympy 1.14 this fixes 4 failing tests in
test/unittests(indices_testserialization,test_to_str,test_flat_body, and the comprehensive round trip). Before: 6 failed, 216 passed. After: 2 failed, 220 passed. The 2 left are theassert_calls that #49 already covers.