This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Conversation
…ct-Python-OidcRP into incl_oidcservice
Include oidcservice in OidcRP
peppelinux
approved these changes
May 12, 2021
Member
peppelinux
left a comment
There was a problem hiding this comment.
I approve without any doubts ... But CI fails. we should have a release of oidcmsg before oidc-rp release, that's ok.
Contributor
Author
|
Yes, the order is OidcMsg, OidcRP and lastly Oidc-op. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Too cumbersome to keep 2 packages in synch so we decided to join them into one.
We included oidcservice into OidcRP since the name OidcRP says more about what it's all about than oidcservice.
It's basically a simple merge such that if you have used classes/functions from oidcservice you now should be able to find
them under a similar name where oidcservice is replaced with oidcop.