Repository navigation
Conversation
n7studios
marked this pull request as ready for review
November 13, 2026 06:03
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
November 13, 2026 06:03
noelherrick
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_broadcast()andupdate_sequence_email()sent a default for a parameter even when it wasn't specified, overwriting the existing value:update_broadcast()always sentpublic: false, so updating any field of a public broadcast made it non-public.publicis now only sent when specified.update_sequence_email()always sentsend_days: null, which resets the email to the sequence's schedule, so updating any field removed the email's own send days.send_daysis now only sent when specified; pass an empty array to reset.Testing
testUpdatePublicBroadcastWithoutPublic: Test updating a public broadcast's subject keeps it public, with the same dates.testUpdateSequenceEmailSendDays: Test updating a sequence email's subject keeps its send days, and an empty array resets them.Checklist