Skip to content

Broadcasts, Sequence Emails: Don’t send public or send_days when unspecified - #166

Open
n7studios wants to merge 2 commits into
add-allow-content-lossfrom
fix-update-unsupplied-params
Open

n7studios wants to merge 2 commits into
add-allow-content-lossfrom
fix-update-unsupplied-params

Conversation

@n7studios

Copy link
Copy Markdown
Contributor

Summary

update_broadcast() and update_sequence_email() sent a default for a parameter even when it wasn't specified, overwriting the existing value:

  • update_broadcast() always sent public: false, so updating any field of a public broadcast made it non-public. public is now only sent when specified.
  • update_sequence_email() always sent send_days: null, which resets the email to the sequence's schedule, so updating any field removed the email's own send days. send_days is now only sent when specified; pass an empty array to reset.

Testing

  • testUpdatePublicBroadcastWithoutPublic: Test updating a public broadcast's subject keeps it public, with the same dates.
  • testUpdateSequenceEmailSendDays: Test updating a sequence email's subject keeps its send days, and an empty array resets them.

Checklist

@n7studios n7studios added this to the 2.9.0 milestone Nov 12, 2026
@n7studios n7studios self-assigned this Nov 12, 2026
@n7studios n7studios added the bug label Nov 12, 2026
@n7studios
n7studios marked this pull request as ready for review November 13, 2026 06:03
@n7studios
n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team November 13, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants