Skip to content

feat(transaction-controller): gate future resimulation by trust - #10747

Merged
dan437 merged 2 commits into
mainfrom
conf-2074-limit-future-resimulation
Oct 8, 2026
Merged

dan437 merged 2 commits into
mainfrom
conf-2074-limit-future-resimulation

Conversation

@dan437

@dan437 dan437 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Add an optional trust callback to TransactionController. Trusted transactions continue to re-simulate on the current block, while untrusted transactions keep the future-block timestamp used to detect time-dependent behavior.

The callback defaults to untrusted, so existing consumers keep their current behavior until they explicitly provide trust data.

References

  • Related to CONF-2074

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Changes re-simulation timing for security-sensitive paths; incorrect trust classification could skip future-block checks on malicious or mismatched txs.

Overview
Adds an optional isTransactionTrusted callback on TransactionControllerOptions so hosts can mark transactions that only touch trusted contracts. On re-simulation, shouldResimulate still runs for security alerts and value/native-balance mismatches, but future-block blockTime (used to surface time-dependent behavior) is applied only when the transaction is not trusted.

The callback defaults to always untrusted (false), so existing integrations keep today’s future-block re-simulation until they wire trust explicitly. Changelog and tests cover the new option and trusted vs untrusted blockTime behavior.

Reviewed by Cursor Bugbot for commit 8761887. Bugbot is set up for automated code reviews on this repo. Configure here.

@dan437
dan437 marked this pull request as ready for review October 8, 2026 13:30
@dan437
dan437 requested review from a team as code owners October 8, 2026 13:30
@dan437
dan437 deployed to default-branch October 8, 2026 13:30 — with GitHub Actions Active
@dan437
dan437 added this pull request to the merge queue Oct 8, 2026
Merged via the queue into main with commit cfba919 Oct 8, 2026
119 checks passed
@dan437
dan437 deleted the conf-2074-limit-future-resimulation branch October 8, 2026 16:27

This branch was successfully deployed

1 active deployment
default-branch — 87618872 Deployed Oct 8, 2026 by dan437 via Determine whether this PR is a release PR #5273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants