Repository navigation
fix(cryptography): only pass AES-GCM additionalData when provided - #10757
Merged
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
gantunesr
approved these changes
Oct 8, 2026
mathieuartu
enabled auto-merge
October 8, 2026 18:28
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Oct 10, 2026
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Patch-level dependency propagation with a narrow AES-GCM Web Crypto compatibility fix; no breaking API or logic changes in this PR’s diff. > > **Overview** > **Monorepo release 1321.0.0** that publishes **`@metamask/cryptography@1.1.2`** and rolls that fix through **`@metamask/profile-sync-controller@34.0.3`** and every package that depends on profile sync. > > The substantive change being released is in **cryptography**: AES-GCM **`encrypt`/`decrypt` no longer pass `additionalData: undefined` into Web Crypto**, which Chrome rejects ([MetaMask#10757](MetaMask#10757)). Profile sync bumps its **`@metamask/cryptography`** range to **`^1.1.2`** ([MetaMask#10761](MetaMask#10761)); changelogs and **`package.json`** across account-tree, assets, bridge, claims, core-backend, kyc, notifications, profile*, ramps, shield, smart-transactions, social, subscription, and related workspaces now require **`@metamask/profile-sync-controller@^34.0.3`**. **`yarn.lock`** is updated to match. > > There are **no new controller or service code changes** in this diff—only version bumps, changelog entries, and lockfile updates. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 003c8a8. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Low Risk
Small WebCrypto call-shape fix for omitted associated data; no change when
additionalDatais explicitly provided.Overview
Fixes AES-GCM encrypt and decrypt failing in browsers (e.g. Chrome) when callers omit associated data.
The WebCrypto parameter objects no longer include an
additionalDatakey with valueundefined;additionalDatais only spread into the algorithm descriptor whenoptions.additionalDatais set. Behavior when associated data is supplied is unchanged.Adds Jest spies on
crypto.subtle.encrypt/decryptto assert the property is absent when no associated data is passed, and documents the fix in the package changelog.Reviewed by Cursor Bugbot for commit d9b53ab. Bugbot is set up for automated code reviews on this repo. Configure here.