Skip to content

Fix a typo and correct the directory path when auto downloading dataset - #20

Merged
henrytsui000 merged 2 commits into
MultimediaTechLab:mainfrom
SamWang0807:main
Jun 3, 2024
Merged

henrytsui000 merged 2 commits into
MultimediaTechLab:mainfrom
SamWang0807:main

Conversation

@SamWang0807

@SamWang0807 SamWang0807 commented Jun 2, 2024 •

Copy link
Copy Markdown
Contributor

In dataset_preparation.py, the path that stores the downloaded dataset should be under "final_path", instead of "extract_to".
Also, import path of "custom_logger" function typo is fixed.

  • The code follows the Python style guide.
  • Code and files are well organized.
  • All tests pass.
  • New code is covered by tests.
  • We would be very happy if gitmoji😆 could be used to assist the commit message💬!

@henrytsui000

Copy link
Copy Markdown
Member

Hi Sam,

Thank you for your contributions! I've reviewed the changes and they look good to me. All tests are passing, which is great. I'll proceed with merging this PR.

Thanks again for your attention to detail and your efforts!

Best regards,
Henry Tsui

@henrytsui000
henrytsui000 merged commit 24b85bd into MultimediaTechLab:main Jun 3, 2024
mapo80 pushed a commit to mapo80/YOLO that referenced this pull request Jan 4, 2026
…et (MultimediaTechLab#20)

* 🐛 [Fix] path error when preparing dataset

* ✏️ [Update] import typos in dataset_preparation.py
mapo80 pushed a commit to mapo80/YOLO that referenced this pull request Jan 4, 2026
…et (MultimediaTechLab#20)

* 🐛 [Fix] path error when preparing dataset

* ✏️ [Update] import typos in dataset_preparation.py
mapo80 added a commit to mapo80/YOLO that referenced this pull request Jan 24, 2026
…et (MultimediaTechLab#20)

* 🐛 [Fix] path error when preparing dataset

* ✏️ [Update] import typos in dataset_preparation.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants