cuda.core: reject negative IPC allocation fds under -O (Glasswing V3.2)#2219
Merged
Andy-Jost merged 1 commit intoJun 15, 2026
Merged
Conversation
Replace assert handle >= 0 with an explicit ValueError so fd validation is not stripped when CPython runs with -O (Glasswing V3.2 / NVBugs 6268893).
This comment has been minimized.
This comment has been minimized.
|
Andy-Jost
added a commit
to Andy-Jost/cuda-python
that referenced
this pull request
Jul 8, 2026
Add a Highlights section, backfill PR/issue links on New features entries, and add Bug fixes entries for the v1.1.0 IPC import hardening (NVIDIA#2219, NVIDIA#2223, NVIDIA#2224), the ManagedBuffer.accessed_by torn-state fix (NVIDIA#2222), and graph node attachment lifetimes (NVIDIA#2280). Highlights (per review): the .pyi type-stub support and the new cuda.core.texture module; NVLink enumeration is covered in New features / Bug fixes rather than as a highlight. Also adds a New features entry for the cuda.core.texture module (NVIDIA#467, NVIDIA#2095, NVIDIA#2307).
Andy-Jost
added a commit
to Andy-Jost/cuda-python
that referenced
this pull request
Jul 8, 2026
Add a Highlights section, backfill PR/issue links on New features entries, and add Bug fixes entries for the v1.1.0 IPC import hardening (NVIDIA#2219, NVIDIA#2223, NVIDIA#2224), the ManagedBuffer.accessed_by torn-state fix (NVIDIA#2222), and graph node attachment lifetimes (NVIDIA#2280). Highlights (per review): the .pyi type-stub support and the new cuda.core.texture module; NVLink enumeration is covered in New features / Bug fixes rather than as a highlight. Also adds a New features entry for the cuda.core.texture module (NVIDIA#467, NVIDIA#2095, NVIDIA#2307).
Andy-Jost
added a commit
that referenced
this pull request
Jul 8, 2026
* docs(core): finalize 1.1.0 release notes Add a Highlights section, backfill PR/issue links on New features entries, and add Bug fixes entries for the v1.1.0 IPC import hardening (#2219, #2223, #2224), the ManagedBuffer.accessed_by torn-state fix (#2222), and graph node attachment lifetimes (#2280). Highlights (per review): the .pyi type-stub support and the new cuda.core.texture module; NVLink enumeration is covered in New features / Bug fixes rather than as a highlight. Also adds a New features entry for the cuda.core.texture module (#467, #2095, #2307). * Reorder API refs + ensure each section has currentmodule the compilation toolchain is one of the unique selling points of cuda.core, but we are burying it deeply --------- Co-authored-by: Leo Fang <leof@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses Glasswing security finding V3.2 (NVBUG 6268893):
IPCAllocationHandle._initusedassert handle >= 0, which CPython strips under-O. Replace with an explicitValueErrorso negative allocation handles (fds) are always rejected.Changes
cuda_core/cuda/core/_memory/_ipc.pyx: raiseValueErrorwhenhandle < 0instead of assertingcuda_core/tests/memory_ipc/test_errors.py: addtest_ipc_allocation_handle_rejects_negative_fdTest Coverage
test_ipc_allocation_handle_rejects_negative_fd— verifiesIPCAllocationHandle._init(-1, None)raisesValueErrorwith the expected message (behavior preserved under-O)Related Work