Fix pre-commit CI#2323
Merged
Merged
Conversation
leofang
approved these changes
Jul 8, 2026
This comment has been minimized.
This comment has been minimized.
|
Member
|
Thanks, Mike! Weird that the assignee check failed but the PR is merged... 🤔 |
Contributor
It was never made merge-blocking. The history is that Rob started it, I helped a little with follow-up work, and I think we both wanted to let it run for a while and confirm it was stable before making it required. We never got back to that last step. Should I create an issue so we don’t forget? |
Member
|
Ah I just made it required and was about to circle back and leave a paper trail here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numpy 2.5.0 introduced new syntax in their
.pyifile that is not supported on Pythons prior to 3.12.0. We tell mypy that we must support all the way back to Python 3.10, so this fails with:Pinning to unblock CI.
This doesn't seem to be a bug on Numpy's part, since they only claim to support Python 3.12 currently.