Skip to content

Migrate MSVC toolchain setup to step-security/msvc-dev-cmd fork#2325

Merged
leofang merged 1 commit into
NVIDIA:mainfrom
leofang:leof/msvc-dev-cmd-step-security
Jul 8, 2026
Merged

Migrate MSVC toolchain setup to step-security/msvc-dev-cmd fork#2325
leofang merged 1 commit into
NVIDIA:mainfrom
leofang:leof/msvc-dev-cmd-step-security

Conversation

@leofang

@leofang leofang commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

Migrates the Windows MSVC-toolchain setup step from
ilammy/msvc-dev-cmd to the
maintained fork
step-security/msvc-dev-cmd@v1.13.1.

Motivation

The upstream ilammy/msvc-dev-cmd still runs on Node.js 20, which GitHub
Actions is deprecating:

Actions will be forced to run with Node.js 24 by default starting June 16th, 2026.
Node.js 20 will be removed from the runner on September 16th, 2026.

The step-security fork has been upgraded to Node.js 24.

Test plan

  • Windows build/wheel workflows pass on the PR
  • Coverage workflow completes on Windows

The upstream ilammy/msvc-dev-cmd is unmaintained and still runs on
Node.js 20, which GitHub Actions is deprecating (removal on
September 16th, 2026). step-security/msvc-dev-cmd@v1.13.1 is a
maintained fork upgraded to Node.js 24.

coverage.yml also gains SHA pinning; it was previously tag-pinned
to @v1.
@copy-pr-bot

copy-pr-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Jul 8, 2026
@leofang leofang self-assigned this Jul 8, 2026
@leofang leofang added the P1 Medium priority - Should do label Jul 8, 2026
@leofang

leofang commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

/ok to test 817594d

@leofang leofang marked this pull request as ready for review July 8, 2026 17:07
@github-actions

This comment has been minimized.

@leofang leofang added this to the cuda.core v1.1.0 milestone Jul 8, 2026
@leofang leofang merged commit a901bba into NVIDIA:main Jul 8, 2026
109 of 110 checks passed
@leofang leofang deleted the leof/msvc-dev-cmd-step-security branch July 8, 2026 18:03
@leofang

leofang commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Thanks, Ralf!

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure P1 Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants