[doc-only] cuda.core: initialize context in graph shutdown test#2375
Merged
Conversation
The subprocess does not inherit the pytest init_cuda fixture context. Set its device current before adding the host callback node so the probe reaches the shutdown-cleanup behavior it is intended to test.
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Andy-Jost
self-requested a review
July 16, 2026 17:17
rwgk
marked this pull request as ready for review
July 16, 2026 22:57
Contributor
Author
|
Thanks @Andy-Jost! |
rwgk
enabled auto-merge (squash)
July 16, 2026 22:57
This comment has been minimized.
This comment has been minimized.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intended to exercise.
Root Cause
test_pending_cleanup_is_safe_during_python_shutdown, added in #2371, runsits probe in a fresh Python subprocess. The parent test's
init_cudafixturedoes not provide a CUDA context to that subprocess. Constructing
Device()initializes CUDA, but does not make the device context current, so adding the
host callback node can fail with
CUDA_ERROR_INVALID_VALUEbefore the shutdownbehavior is tested.
Explicitly call
device.set_current()before constructing the graph.Testing
pre-commit run --all-filespassed.