Fix outdated unique modifier data - #10324
Conversation
| Implicits: 1 | ||
| CriticalStrikeChanceImplicitDagger1 | ||
| Implicits: 2 | ||
| {variant:1}CriticalStrikeChanceImplicitDagger1 |
There was a problem hiding this comment.
The dagger-implicit migration is incomplete for the two Boot Knife uniques later in this file. Ungil's Gauche and Replica Ungil's Gauche still use the untagged CriticalStrikeChanceImplicitDagger1, so PoB applies the fixed 30% implicit to their Current selections. Exact-name fetches from GGG's Allflame trade API return both with stat.implicit.stat_587431675 and magnitude bounds 40-45%. This understates their current global critical strike chance by 10-15 percentage points. The same Pre 3.29.0/Current split used here can represent both definitions without losing the legacy value.
AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed against the official trade API.
| Source: Drops from unique{The Searing Exarch} (Uber) | ||
| Requires Level: 53, 77 Str | ||
| LocalIncreasedPhysicalDamageReductionRatingPercentUnique__19 | ||
| LocalIncreasedPhysicalDamageReductionRatingPercentUnique__19[100,150] |
There was a problem hiding this comment.
This fixed override drops a legacy range that still exists in Standard. An exact-name official trade search for The Celestial Brace with explicit.stat_1062208444 <= 99 returned a live copy rolled at 97% increased Armour; the same API record reports the modifier's current magnitude bounds as 100-150%. Because this definition has no variants, the change makes PoB expose only 100-150%, whereas the previous 80-120% mapping could represent that verified legacy roll. A legacy 80-120% / current 100-150% variant split would preserve both ranges and match the PR's stated Standard-verification rule.
AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed against the official trade API.
Fixes # .
Description of the problem being solved:
Updates outdated modifier IDs, ranges, and variant handling for 33 unique items. I obviously used an LLM here to help with this work, but I manually verified every modifier line in both standard and trade league.
The changes were determined by comparing:
ModTextMap.luaandModItemExclusive.luaLegacy variants were added only where Standard items confirmed that the previous modifier still exists.
Changes
40%and current50–55%variants.CriticalStrikeChanceImplicitDaggerNew2; Standard confirms the old implicit still exists.20–24 to 36–46to20–24 to 38–46. Replaced the override withSpellAddedFireDamageUnique__3.30%and current40–45%variants. Changed current Chaos Resistance from17–27%to17–29%.30%and current40–45%variants.40–50%to30–50%and replacedTalismanIncreasedCriticalChancewithCriticalStrikeChanceUnique__6.30%and current40–45%variants.30%and current40–45%variants.120–150% increased Spell Damagemodifier to the Current variant.200%to180–220%.40%and current50–55%variants.50–70to60–70.30%and current40–45%variants.30%and current40–45%variants.30%and current40–45%variants.15–30%to20–30%and replacedFlaskManaRecoveryUnique__1withBeltFlaskManaRecoveryUnique__1.50%and current60–65%variants.30%and current40–45%variants.25–35%to40–60%by removing the stale override.CriticalStrikeChanceUniqueGlovesStr3already contains the correct current range.100–200%to fixed100%and replaced the previous modifier withFireDamagePercentUnique__12___.100%; no evidence was found that a separate100–200%legacy explicit existed.30%and current40–45%variants.30%and current40–45%variants.30%and current40–45%variants.10–15%to5–15%by removing the override.ItemFoundRarityIncreaseUnique__7currently maps to5–15%.20–30%to25–30%and replaced literal text withAttackSpeedChangedStanceUnique__1.35–39% increased Spell Damageimplicit toSpellDamageOnWeaponImplicitWand16and separated it from the legacy modifier.AbyssJewelSocketUnique__1[3,3]withAbyssJewelSocketUnique__16for the three-socket Current variant.25–35 to 60–65to25–35 to 50–65.30%and current40–45%variants.80–120%to100–150%.40%and current50–55%variants.30%and current40–45%variants.25–40%to30–40%.30%and current40–45%variants.Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: