Fix "Tukohama, War's Herald" breaking fist of war support gem - #10325
Closed
vaisest wants to merge 2 commits into
Closed
Fix "Tukohama, War's Herald" breaking fist of war support gem#10325vaisest wants to merge 2 commits into
vaisest wants to merge 2 commits into
Conversation
…pporting skills granted by items" PathOfBuildingCommunity#10310
mcagnion
reviewed
Sep 5, 2026
| if not fromItemReplacements[grantedEffect] then | ||
| local taggedGrantedEffect = copyTable(grantedEffect, true) | ||
| taggedGrantedEffect.fromItem = true | ||
| fromItemReplacements[grantedEffect] = taggedGrantedEffect |
Contributor
There was a problem hiding this comment.
With Fireball and a level 15 Added Cold Damage gem socketed together in Bitterdream, this change applies Added Cold Damage twice. In this reproduction, enabling the gem raises average damage from 1413.86 to 1945.02 and mana cost from 41 to 49; before this change, enabling it changes neither value.
The copied support definition is no longer recognized as the same support by addBestSupport, so both copies enter the calculation.
AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused reproduction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10310.
Description of the problem being solved:
It seems the
grantedEffect.fromItem = trueline was actually modifying the global table which means evaluating the tree node broke the actual support gem until the client was restarted. This works around that by copying the table in initEnv(). This seems to have fixed the problem without breaking other tests, but I'm not really convinced it can't be a problem elsewhereSteps taken to verify a working solution:
Link to a build that showcases this PR:
See issue
Before screenshot:
After screenshot: