You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the move to IGSIO for some functionality, vtkPlusLogger inherits from vtkIGSIOLogger but creates a separate instance. So my application which used to set log level to 5 now does not get all the messages, because Plus internals now use vtkIGSIOLogger which is a separate instance from vtkPlusLogger.
Expected behavior: there is a single logger instance, and vtkPlusLogger is an empty descendant, or even better just a rename using vtkPlusLogger = vtkIGSIOLogger;
It looks like I have mistaken about two instances - there seems to be a single instance. However, SetLogLevel(5) is not respected. The errors from vtkPlusTimestampedCircularBuffer and vtkPlusBuffer are not logged.
Activity
dzenanz commentedon Feb 8, 2019
It looks like I have mistaken about two instances - there seems to be a single instance. However, SetLogLevel(5) is not respected. The errors from vtkPlusTimestampedCircularBuffer and vtkPlusBuffer are not logged.
dzenanz commentedon Feb 8, 2019
Setting the logging level has no effect if done before this statement:
vtkPlusConfig::GetInstance()->SetDeviceSetConfigurationData(configRootElement);Either
vtkIGSIOLogger::Instance()->SetLogLevel(5);orvtkPlusLogger::Instance()->SetLogLevel(5);work after that statement.Is this expected? Is this documented somewhere?
Sunderlandkyl commentedon Feb 11, 2019
I don't think that this is expected behavior, seems like a bug.
I'll take a look at it.
dzenanz commentedon Feb 12, 2019
That fixed it. Thanks!
fix PlusToolkit#493: Stop log error from being overwritten by config …
fix PlusToolkit#493: Stop log error from being overwritten by config …
fix PlusToolkit#493: Stop log error from being overwritten by config …