Skip to content

upgrade dpp to v10.1.3 - #705

Merged
pifopi merged 13 commits into
PokemonAutomation:mainfrom
naussika:main
Oct 8, 2025
Merged

pifopi merged 13 commits into
PokemonAutomation:mainfrom
naussika:main

Conversation

@naussika

@naussika naussika commented Oct 4, 2025 •

Copy link
Copy Markdown
Contributor

in case you want to upgrade dpp to v10.1.3 (latest as of now)

  • use homebrew installed dpp on macOS;
  • import dpp libs/headers of v10.1.3 for Windows (and update cmake accordingly);

@pifopi
pifopi marked this pull request as draft October 4, 2025 14:01
@naussika naussika changed the title [WIP] upgrade dpp to v10.1+ [WIP] upgrade dpp to v10.1.3 Oct 4, 2025
@pifopi

pifopi commented Oct 4, 2025 •

Copy link
Copy Markdown
Member

Thank you very much for updating the dpp lib on mac ! For windows, the dll is now different between debug and release so this is needed though
naussika#1

@pifopi
pifopi marked this pull request as ready for review October 4, 2025 14:19
@pifopi

pifopi commented Oct 4, 2025

Copy link
Copy Markdown
Member

All good for me ! Thanks again

@naussika naussika changed the title [WIP] upgrade dpp to v10.1.3 upgrade dpp to v10.1.3 Oct 4, 2025
@naussika

naussika commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

@pifopi pifopi mentioned this pull request Oct 4, 2025
Comment thread 3rdParty/dpp/nlohmann/json.hpp Resolved
Comment thread 3rdParty/dpp/nlohmann/json_fwd.hpp Resolved
@pifopi

pifopi commented Oct 6, 2025

Copy link
Copy Markdown
Member

Is it okay to merge now ?

@pifopi
pifopi merged commit baef321 into PokemonAutomation:main Oct 8, 2025
5 checks passed
naussika added a commit to naussika/Arduino-Source that referenced this pull request Oct 11, 2025
naussika added a commit to naussika/Arduino-Source that referenced this pull request Oct 11, 2025
Mysticial pushed a commit that referenced this pull request Oct 12, 2025
colefoster pushed a commit to colefoster/mimikyu-old that referenced this pull request May 13, 2026
* update CMakeLists.txt to use brewed dpp

* DppIntegration: upgrade to libdpp v10.1+

* remove libdpp_macos_arm64.a

* import include from libdpp v10.1.3

* import libdpp windows lib

* fix debug build

* revert 3rdParty/dpp/nlohmann/

* cmake: update dpp, add missing DPP_DLL_DEBUG, DPP_DLL_RELEASE

* cmake: update for onnxruntime on macOS

---------

Co-authored-by: Ȇ✠Saͥbͣeͫr👑Ⰰ <naussika@users.noreply.github.com>
Co-authored-by: pifopi <dottel.gael@gmail.com>
colefoster pushed a commit to colefoster/mimikyu-old that referenced this pull request May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants