FOUR-31727: Fix DevLink bundle listing and selector search#8889
Open
eiresendez wants to merge 2 commits into
Open
FOUR-31727: Fix DevLink bundle listing and selector search#8889eiresendez wants to merge 2 commits into
eiresendez wants to merge 2 commits into
Conversation
Contributor
|
QA server K8S was successfully deployed https://ci-2ba51b845d.engk8s.processmaker.net |
CarliPinell
reviewed
Jul 1, 2026
CarliPinell
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix — pagination, newest-first ordering, and remote search address the reported DevLink bundle listing issue well, and the new API tests give good coverage.
I left two inline notes on BackendSelect.vue around remote-search UX and request ordering. Neither is a merge blocker from my side.
CarliPinell
approved these changes
Jul 1, 2026
CarliPinell
left a comment
Contributor
There was a problem hiding this comment.
Minor observations. Approved.
|
|
QA server K8S was successfully deployed https://ci-2ba51b845d.engk8s.processmaker.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
FOUR-31727 fixes an issue where DevLink bundles outside the first API page were not available from the UI. To reproduce, create more than 15 local bundles, then go to
/admin/devlink/local-bundlesor open an Add to Bundle modal from a supported asset list. The admin route only displayed the first page of bundles, and the dropdown search could not find bundles that were not already loaded client-side.Solution
How to Test
Automated test run:
vendor/bin/phpunit tests/Feature/Api/DevLinkTest.php --filter LocalBundlesManual verification:
/admin/devlink/local-bundlesand confirm bundles are paginated and newest bundles appear first.Related Tickets & Packages
ci:deploy
.