FOUR-26363 | +Case Pagination Is Not Working Correctly#8896
Open
mcraeteisha wants to merge 3 commits into
Open
FOUR-26363 | +Case Pagination Is Not Working Correctly#8896mcraeteisha wants to merge 3 commits into
mcraeteisha wants to merge 3 commits into
Conversation
Add a new method to handle changing the number of items displayed per page. The method adjusts the current page number if necessary to ensure it doesn't exceed the total number of items, and triggers a data fetch with the updated pagination settings.
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
eiresendez
requested changes
Jul 8, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Issue
Ticket: FOUR-26363
This PR fixes the +Case modal per-page selector so that switching between 15 / 30 / 50 immediately refreshes the visible process list.
Solution
requestModal.vueinheritschangePerPage()fromdatatableMixin, which readsthis.data.meta.totalto clamp the current page. But this component never assignsthis.data;fetch()only writes the response intothis.$refs.listProcess.dataandthis.processes. Sothis.data.metawasundefined, the shared handler threw before reachingthis.fetch(), and the list never refreshed.The solution was to override
changePerPage(value)inresources/js/components/requests/requestModal.vueto read the total fromthis.$refs.listProcess.tablePagination(the same sourceonPageChangealready uses), guard against the modal's lazily-mounted ref, clamppage, then callfetch(). Mirrors the pattern already used inCasesRetentionLogs.vue, with extra null-safety because this component lives inside a<b-modal>and doesn't fetch oncreated.How To Test
- Ensure the list refreshes immediately, pagination shows "1 – 30 of N" (if 30+ processes exist).
<,>,<<,>>, and direct page numbers to ensure paging still works.ci:deploy
Code Review Checklist