DOC: update docs for setup.py removal, and fix ReadTheDocs build#669
Merged
rgommers merged 2 commits intoPyWavelets:masterfrom Apr 5, 2023
Merged
DOC: update docs for setup.py removal, and fix ReadTheDocs build#669rgommers merged 2 commits intoPyWavelets:masterfrom
rgommers merged 2 commits intoPyWavelets:masterfrom
Conversation
Member
Author
|
RTD doc builds only trigger on merges to master, so I'm inclined to just merge this. In case it doesn't work immediately, I'll have to set up an RTD build on my own fork. |
Member
Author
|
This is all pretty trivial, so I'll hit the green button. |
Member
Author
|
Fixed after commit 5abcc10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RTD build somehow still tries to invoke
setup.pyeven though its docs say that that is deprecated and usingpipis the default. This PR follows the docs at https://docs.readthedocs.io/en/stable/builds.html and adds the recommended.readthedocs.yamlconfig file.