Conversation
|
To pick up the right |
7e826b8 to
dd6330e
Compare
|
The |
|
See matplotlib/matplotlib#26736. Also you may want to look at my comments about the version numbering. I suspect other projects are likely to be using the wrong numbering scheme, since I've seen other projects do similar things. |
|
They are planning matplotlib 3.8 final release this week. That should simplify this PR, so we may want to wait for that release. But I am also happy merging this now and fixing things later. |
Hmm, I thought it wouldn't - but maybe tools have special-cased Python version numbers now in a way that deviates from PEP 440 for convenience. If so, great - fewer things to tweak.
If you need a final release of pywavelets now to make life easier for scikit-image & co, then we can merge this now. Otherwise, maybe easier to wait? No strong preference from me. |
ba9e18e to
3130b4b
Compare
|
Let's give it a few days and see how things progress. It would be good to have a pywt release early next week. I have a few more cleanup PRs I would like to make, so maybe we can get those in as well. |
|
I'm on holiday next week, so if you need it soon it may be useful to do the release by Friday. @grlee77 is that fine with you? Anything you'd like to get in? |
3130b4b to
dd0dc7d
Compare
rgommers
left a comment
There was a problem hiding this comment.
This all LGTM, works as advertised as far as I can tell. In it goes, thanks @jarrodmillman. And thanks for the review @cclauss.
|
The numpy 1.26.0 release will be out today if things go as planned, so let's hold off on modifying the wheel build jobs to deal with pre-releases. |
No description provided.