Skip to content

feat: validator onboarding - #6

Closed
ruseinov wants to merge 1 commit into
v0.2from
ru/feature/onboarding
Closed

ruseinov wants to merge 1 commit into
v0.2from
ru/feature/onboarding

Conversation

@ruseinov

@ruseinov ruseinov commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@ruseinov
ruseinov force-pushed the ru/feature/onboarding branch from 360429d to 4146ee0 Compare October 6, 2026 08:55
@augmentcode

augmentcode Bot commented Oct 6, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Enables Quip validator onboarding with session-key ownership proofs.
Changes:

  • Detects Quip via the runtime specification name.
  • Adds ownership-proof input shared by onboarding and key updates.
  • Validates nonempty, byte-aligned hex and binds proofs to stash and keys.
  • Clears proofs when keys, stash, or the session API changes.
  • Uses the stash account to sign Quip session-key updates.
  • Requires atomic utility.batchAll for Quip onboarding.
  • Retains legacy signing, empty proofs, and batching fallback elsewhere.
Technical Notes: Adds RPC guidance, conditional relay-chain warnings, and regression tests for proof handling, signers, and onboarding availability.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

<Modal.Actions>
<TxButton
accountId={controllerId}
accountId={needsProof ? stashId : controllerId}

@augmentcode augmentcode Bot Oct 6, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the signer/permission mismatch at packages/page-staking/src/Actions/Account/SetSessionKey.tsx:46, since both launch actions still require isOwnController (packages/page-staking/src/Actions/Account/index.tsx:260,341)? With distinct stash/controller accounts on Quip, a stash-only owner cannot open this now-stash-signed operation, while a controller-only owner can queue a transaction they cannot sign.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@ruseinov

Copy link
Copy Markdown
Collaborator Author

Superseded by #9

@ruseinov ruseinov closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant