Repository navigation
fix: keep the Quip signer available in production bundles - #7
Merged
Merged
Conversation
fix: facilitate extrinsic decoding
wrapTx/extractParams run before any queueSetTxStatus call in _onSend and _onSign, so a failure there (e.g. a view-only Quip account with an unavailable signing key) left the queue item pending and stalled auto-submitting queues. Catch, mark the item as error with the underlying message, and rethrow so the modal error handler still fires.
feature: extrinsic signing
feat: falcon integ
`yarn build:www` builds with webpack `mode: 'production'`, and webpack.base.cjs inlines NODE_ENV through DefinePlugin. The `NODE_ENV === 'production'` short-circuit in shouldInjectQuipSigner() therefore folds to a constant `false` in every deployed portal: webpack drops the signer init path and the dev seeds, and QUIP_DEV_SIGNER, `?quipSigner` and the localStorage toggle all stop working. Drop the short-circuit. The signer stays opt-in through those three explicit switches. The spec now checks that a production bundle stays off by default and turns on with QUIP_DEV_SIGNER. Checked with `QUIP_DEV_SIGNER=1 yarn build:www`: with this change the bundle contains "Quip dev signer injected" and "Quip Alice"; without it, neither string is present. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🤖 Augment PR SummaryRemoves the production guard so deployed bundles retain the Quip signer, while preserving environment, query-string, and localStorage opt-in switches. 🤖 Was this summary useful? React with 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4: the production-condition fix mentioned there.
shouldInjectQuipSigner()returnsfalsewheneverNODE_ENV === 'production'.yarn build:wwwbuilds withmode: 'production', so in any deployed portal the signer is compiled out andQUIP_DEV_SIGNER,?quipSignerand the localStorage toggle do nothing. This drops the check. The signer stays opt-in through those three switches. The Quip portal has run this same change since August.Checked locally on v0.2 (0a0f178):
initQuipSigner.spec.tspasses 4/4 (2 fail without the change).QUIP_DEV_SIGNER=1 yarn build:www, the bundle contains "Quip dev signer injected" and "Quip Alice". Without the change, neither string is present.🤖 Generated with Claude Code