Skip to content

concatArrayEagerDelayError documented but missing? 2.16 #6082

Description

@AndreasBackx

On 2.1.16 it is documented in the wiki and on readthedocs that concatArrayEagerDelayError is new in RxJava 2 together with:

Those are all there, but concatArrayEagerDelayError doesn't seem to be implemented:

Observable.concatArrayEagerDelayError()

Am I perhaps missing something?

Activity

  1. akarnokd commented on Jul 16, 2018

    @akarnokd
    Member

    Looks like concatArrayEagerDelayError has not been exposed so far: https://github.com/ReactiveX/RxJava/blob/2.x/src/main/java/io/reactivex/Observable.java#L1341

  2. AndreasBackx commented on Jul 16, 2018

    @AndreasBackx
    Author

    Yes, I've overlooked that, might've been because I'm on my laptop right now and it's chugging along slowly on those large files on GitHub.

    Is the plan to expose this in the future?

  3. akarnokd commented on Jul 16, 2018

    @akarnokd
    Member

    No plans and there was no feature request for them. It would require 6~8 new methods:

    {Flowable|Observable}.concatArrayEagerDelayError([tillTheEnd[, maxConcurrency [, prefetch]]], sources...)

    and at least 2 diagrams per base class.

  4. AndreasBackx commented on Jul 16, 2018

    @AndreasBackx
    Author

    I'm up for providing a PR if that's welcome. Thank you in advance for providing me with the methods that would need to be implemented. I haven't dabbled into the RxJava source, but I guess I can figure it out. What would I need to create the diagrams?

    Looking at the tests for concatArrayEager, and concatArrayDelayError. I assume that I only have to implement the tests like concatArrayDelay but for concatArrayEagerDelayError.

  5. akarnokd commented on Jul 17, 2018

    @akarnokd
    Member

    I draw them in Excel but others use OmniGraffle or Inkscape.

    You can try making a PR.

  6. AndreasBackx commented on Aug 5, 2018

    @AndreasBackx
    Author

    Small update. I was on holiday and am currently studying for exams for another month so it'll be more than a month till I can get to this unfortunately.

  7. akarnokd commented on Aug 6, 2018

    @akarnokd
    Member

    I've done it and the necessary marbles in #6143.

  8. AndreasBackx commented on Aug 6, 2018

    @AndreasBackx
    Author

    Too bad for me, I was looking forward to it. :(

    Great to have it exposed now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions