Skip to content

4.x: Unit test lambdaification 8 of N#8144

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
akarnokd:4xTestLambdaCleanups8
Jun 21, 2026
Merged

4.x: Unit test lambdaification 8 of N#8144
akarnokd merged 1 commit into
ReactiveX:4.xfrom
akarnokd:4xTestLambdaCleanups8

Conversation

@akarnokd

Copy link
Copy Markdown
Member

Will go over the unit tests in ASCII order of the classpath and classes.

Search regexp: new\s+\w+(?:\s*<(?:[\s\w<>(\[\])?,.?]|\s*<[\s\w<>(\[\])?,.?]*>)*>)?\s*\([^)]*\)\s*\{

/* NFI */ = Not Functional Interface so break the regexp pattern

If you complain instead of proposing a PR about "why not convert to method references" you'll be banned.

Related: #8080

@akarnokd akarnokd added this to the 4.0 milestone Jun 21, 2026
@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.732 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableConcatTest.java: 4.576
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableDelayTest.java: 4.866
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableDoOnTest.java: 4.687
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableFromActionTest.java: 4.649
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableFromCallableTest.java: 4.669
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableFromPublisherTest.java: 4.888
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableFromRunnableTest.java: 4.660
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableFromSupplierTest.java: 4.681
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableHideTest.java: 4.818
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableLiftTest.java: 4.855
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableMaterializeTest.java: 4.873
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableMergeIterableTest.java: 4.600
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableMergeTest.java: 4.587
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableObserveOnTest.java: 4.974
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableOnErrorXTest.java: 4.769
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletablePeekTest.java: 4.878
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableRepeatWhenTest.java: 5.013
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableResumeNextTest.java: 4.828
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableSafeSubscribeTest.java: 4.553
src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableSubscribeOnTest.java: 4.892

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (54cd5d4) to head (94ddfd5).

Additional details and impacted files
@@            Coverage Diff            @@
##                4.x    #8144   +/-   ##
=========================================
  Coverage     98.78%   98.78%           
  Complexity     6874     6874           
=========================================
  Files           769      769           
  Lines         48659    48659           
  Branches       6516     6516           
=========================================
  Hits          48067    48067           
+ Misses          456      455    -1     
- Partials        136      137    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd merged commit f768274 into ReactiveX:4.x Jun 21, 2026
6 checks passed
@akarnokd akarnokd deleted the 4xTestLambdaCleanups8 branch June 21, 2026 16:36
@akarnokd akarnokd added the Test label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant