Skip to content

4.x: Scheduler.toExecutorService(boolean) logic fix#8151

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
akarnokd:4xToExecutorLogicFix
Jun 22, 2026
Merged

4.x: Scheduler.toExecutorService(boolean) logic fix#8151
akarnokd merged 1 commit into
ReactiveX:4.xfrom
akarnokd:4xToExecutorLogicFix

Conversation

@akarnokd

Copy link
Copy Markdown
Member

The toExecutorService(boolean) lacked the implementation to really chose between the worker and the direct methods.

@akarnokd akarnokd added this to the 4.0 milestone Jun 22, 2026
@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.721 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeDelayErrorTest.java: 4.729
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeMaxConcurrentTest.java: 4.676
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeTest.java: 4.748
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeWithCompletableTest.java: 4.758
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeWithMaybeTest.java: 4.576
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeWithSingleTest.java: 4.562
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableObserveOnTest.java: 4.598
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnBackpressureBufferStrategyTest.java: 4.953
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnBackpressureBufferTest.java: 4.785
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnBackpressureDropTest.java: 4.792
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnBackpressureErrorTest.java: 4.996
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnBackpressureLatestTest.java: 4.666
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnBackpressureReduceTest.java: 4.759
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnBackpressureReduceWithTest.java: 4.623
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnErrorResumeNextViaFlowableTest.java: 4.669
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnErrorResumeNextViaFunctionTest.java: 4.769
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableOnErrorReturnTest.java: 4.677
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowablePublishFunctionTest.java: 4.640
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowablePublishMulticastTest.java: 4.717

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.78%. Comparing base (3824963) to head (ba74074).
⚠️ Report is 1 commits behind head on 4.x.

Files with missing lines Patch % Lines
...main/java/io/reactivex/rxjava4/core/Scheduler.java 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8151      +/-   ##
============================================
- Coverage     98.79%   98.78%   -0.02%     
  Complexity     6880     6880              
============================================
  Files           769      769              
  Lines         48659    48659              
  Branches       6516     6516              
============================================
- Hits          48074    48066       -8     
- Misses          443      449       +6     
- Partials        142      144       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd merged commit f6663da into ReactiveX:4.x Jun 22, 2026
5 of 6 checks passed
@akarnokd akarnokd deleted the 4xToExecutorLogicFix branch June 22, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant