Skip to content

4.x: Cleanup; build, safevarargs, small typos#8183

Merged
akarnokd merged 5 commits into
ReactiveX:4.xfrom
akarnokd:4xCleanups3
Jun 26, 2026
Merged

4.x: Cleanup; build, safevarargs, small typos#8183
akarnokd merged 5 commits into
ReactiveX:4.xfrom
akarnokd:4xCleanups3

Conversation

@akarnokd

Copy link
Copy Markdown
Member
  • Fix 'cancelled' to 'canceled'
  • Fix unnecessary @SafeVarargs with CompletableSource....
  • Add Gradle test timeout of 30 minutes
  • Cleanup build.gradle redundancies and deprecations

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 5.083 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

.github/workflows/gradle_branch.yml: 5.083
.github/workflows/gradle_pr.yml: 4.933
.github/workflows/gradle_preview_jdks.yml: 5.129
.github/workflows/gradle_release.yml: 5.211
.github/workflows/gradle_snapshot.yml: 5.059

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.33%. Comparing base (a23d855) to head (bf4421f).

Files with missing lines Patch % Lines
...ctivex/rxjava4/core/CompletionStageDisposable.java 33.33% 2 Missing ⚠️
...ain/java/io/reactivex/rxjava4/core/Streamable.java 0.00% 1 Missing ⚠️
...nternal/schedulers/SchedulerToExecutorService.java 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (69.23%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8183      +/-   ##
============================================
- Coverage     98.33%   98.33%   -0.01%     
+ Complexity     6938     6934       -4     
============================================
  Files           785      785              
  Lines         49003    48999       -4     
  Branches       6603     6599       -4     
============================================
- Hits          48187    48182       -5     
+ Misses          625      622       -3     
- Partials        191      195       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 5.083 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

.github/workflows/gradle_branch.yml: 5.083
.github/workflows/gradle_pr.yml: 4.933
.github/workflows/gradle_preview_jdks.yml: 5.129
.github/workflows/gradle_release.yml: 5.211
.github/workflows/gradle_snapshot.yml: 5.059

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 5.083 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

.github/workflows/gradle_branch.yml: 5.083
.github/workflows/gradle_pr.yml: 4.933
.github/workflows/gradle_preview_jdks.yml: 5.129
.github/workflows/gradle_release.yml: 5.211
.github/workflows/gradle_snapshot.yml: 5.059

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 5.083 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

.github/workflows/gradle_branch.yml: 5.083
.github/workflows/gradle_pr.yml: 4.933
.github/workflows/gradle_preview_jdks.yml: 5.129
.github/workflows/gradle_release.yml: 5.211
.github/workflows/gradle_snapshot.yml: 5.059

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 5.083 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

.github/workflows/gradle_branch.yml: 5.083
.github/workflows/gradle_pr.yml: 4.933
.github/workflows/gradle_preview_jdks.yml: 5.129
.github/workflows/gradle_release.yml: 5.211
.github/workflows/gradle_snapshot.yml: 5.059

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@akarnokd akarnokd merged commit 5091ed2 into ReactiveX:4.x Jun 26, 2026
5 of 6 checks passed
@akarnokd akarnokd deleted the 4xCleanups3 branch June 26, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant