Implement macOS cursor setting and hiding support#280
Open
SpruceCloud wants to merge 1 commit into
Open
Conversation
3fb9adc to
b7fb47b
Compare
prokopyl
requested changes
Jul 10, 2026
prokopyl
left a comment
Member
There was a problem hiding this comment.
Hi, and thanks for this PR!
The main issue I have is that you should use the safe APIs provided by objc2, instead of using the error-prone and unsafe msg_send! macro.
Other than that, this looks pretty good to me!
| self.state.closed.set(true); | ||
| if self.state.cursor_hidden.get() { | ||
| unsafe { | ||
| let _: () = objc2::msg_send![objc2_app_kit::NSCursor::class(), unhide]; |
Member
There was a problem hiding this comment.
This should use NSCursor::unhide directly, instead of using a raw, unsafe msg_send call
| unsafe { | ||
| if let Some(loaded_cursor) = native_cursor.load() { | ||
| if self.inner.state.cursor_hidden.get() { | ||
| let _: () = objc2::msg_send![objc2_app_kit::NSCursor::class(), unhide]; |
Member
There was a problem hiding this comment.
Same as above, this should use the safe APIs instead of msg_send here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #211 , merging the mouse changes as a separate commit.
Took a bit longer, but now I am focused on finishing the changes.