Skip to content

Enable access to localhost:8080/h2#144

Closed
gicalin wants to merge 1 commit into
SAP-samples:mainfrom
gicalin:main
Closed

Enable access to localhost:8080/h2#144
gicalin wants to merge 1 commit into
SAP-samples:mainfrom
gicalin:main

Conversation

@gicalin

@gicalin gicalin commented Jun 10, 2022

Copy link
Copy Markdown

Small technical contribution to be able to see and change entries directly in h2 while the apps are running.

@cla-assistant

cla-assistant Bot commented Jun 10, 2022

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Georgel Calin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant

cla-assistant Bot commented Jun 10, 2022

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Georgel Calin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gicalin gicalin closed this Jun 10, 2022
@gicalin gicalin reopened this Jun 10, 2022
@beckermarc
beckermarc self-requested a review June 10, 2022 13:45

@beckermarc beckermarc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!! :)

I am however not sure, if we want to promote adding the h2 console path to the public endpoints by default. Another thing to consider: We have improved the support for Spring Boot Dev Tools with our latest CAP Java release. When adding Spring Boot Dev Tools the H2 Console is automatically enabled during development. Therefore these changes are no longer necessary when we add this dependency (#145)

The security config concern could however also be solved by introducing a dedicated security config that is only available in the default profile.

@gicalin

gicalin commented Jun 10, 2022

Copy link
Copy Markdown
Author

Closing since I understand the change is not needed.

@gicalin gicalin closed this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants