Repository navigation
DumpTPCchannelStatusDB: module to dump on screen TPC channel status - #811
Conversation
It comes with two kind-of-art-independent algorithms.
|
Surprise! I am a reviewer! How would I have known this if I didn't happen to look here? |
SFBayLaser
left a comment
There was a problem hiding this comment.
Is it possible to not only output the channel number, but provide an option to output in electronics space values?
|
I'm going through old PRs and it looks like this one never got approved. Were Tracy's comments ever addressed? I realize the number of changes is quite large, but I hope your relative familiarity with the code will make things easier. Do y'all have time to review this PR or should I ask someone else? |
|
@SFBayLaser and @dtorretta56, Can you both give formal approval if this PR is good to go? |
dtorretta56
left a comment
There was a problem hiding this comment.
was this tested?
if so, I approve.
|
trigger build larsoft@v10_27_00 LArSoft/lar*@LARSOFT_SUITE_v10_27_00 SBNSoftware/sbnalg@v10_27_00 SBNSoftware/sbnobj@v10_27_00 SBNSoftware/sbnanaobj@v10_27_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbncode@v10_27_00 SBNSoftware/icarusalg@v10_27_00 SBNSoftware/icarusutil@v10_24_00 SBNSoftware/icarus_signal_processing@v10_25_00 |
There was a problem hiding this comment.
🟡 Changes recommended
The generic dumper’s constructor rejects the const provider exposed by the art-managed service, blocking its intended use.
3 open issues
What changed in this PR
Adds TPC channel-status dumping utilities for ICARUS, supporting configured timestamps and read-only inspection of the current provider state.
Changes:
- Adds generic and timestamp-aware dumping algorithms.
- Adds an art module and build registration.
- Provides a standalone configuration that writes the latest status to a log file.
| File | Description |
|---|---|
| icaruscode/TPC/Utilities/TPCSIOVchannelStatusDBdumper.h | Declares timestamp-aware dumping API. |
| icaruscode/TPC/Utilities/TPCSIOVchannelStatusDBdumper.cxx | Selects timestamps and formats dump boundaries. |
| icaruscode/TPC/Utilities/TPCchannelStatusDBdumper.h | Declares read-only dumping API and settings. |
| icaruscode/TPC/Utilities/TPCchannelStatusDBdumper.cxx | Prints channel states and summaries. |
| icaruscode/TPC/Utilities/DumpTPCchannelStatusDB_module.cc | Runs configured dumps at job startup. |
| icaruscode/TPC/Utilities/CMakeLists.txt | Registers the new module. |
| fcl/utilities/dump_tpc_channelstatus_latest_icarus.fcl | Configures latest-status dumping to a log file. |
Review effort: Balanced
| /// Configures and sets up the algorithm. | ||
| TPCchannelStatusDBdumper( | ||
| Config const& config, | ||
| lariov::ChannelStatusProvider& channelStatus, unsigned int nChannels |
There was a problem hiding this comment.
Right... except that it did not fail compilation. 🤷
There was a problem hiding this comment.
To clarify: passing the art-managed service would make compilation fail.
The module in this PR:
- instantiates a new copy of the service provider
- uses the derived algorithm
lariov::TPCSIOVchannelStatusDBdumper, which needs a non-const version of the provider, to probe different timestamps as requested in the configuration.
|
It could be worth @PetrilloAtWork glancing at the CoPilot items... |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
61491a8 to
7a2eff9
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
7a2eff9 to
fefd8f5
Compare
|
trigger build larsoft@v10_27_00 LArSoft/lar*@LARSOFT_SUITE_v10_27_00 SBNSoftware/sbnalg@v10_27_00 SBNSoftware/sbnobj@v10_27_00 SBNSoftware/sbnanaobj@v10_27_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbncode@v10_27_00 SBNSoftware/icarusalg@v10_27_00 SBNSoftware/icarusutil@v10_24_00 SBNSoftware/icarus_signal_processing@v10_25_00 |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |

The new art module
DumpTPCchannelStatusDBis able to dump the content of the TPC channel status service providerlariov::SIOVChannelStatusProvider(the one used by ICARUS) on screen for the timestamps specified in configuration.A self-standing job configuration
dump_tpc_channelstatus_latest_icarus.fclis provided, which uses the standard ICARUSChannelStatusServiceconfiguration and dumps the channel status information pertaining the most recent time. This is today's output:It pull request comes with two kind-of-art-independent algorithms.
One,
lariov::TPCSIOVchannelStatusDBdumper, is the backend of the moduleDumpTPCchannelStatusDBand works only withSIOVChannelStatusProvider, using its specific interface to select the timestamps. It should not be used on the art-managed serviceChannelStatusService, since the algorithm and art will compete in setting the timestamps.The other,
lariov::TPCchannelStatusDBdumper, works with anyChannelStatusProvider(including the one managed by art) and dumps only the current channel status, whatever time it refers to (ChannelStatusProviderinterface does not have the concept of time). This is a dumping algorithm suitable to be used in aproduce()oranalyze()module method, since it will not change the status of the service it is dumping.Note that while the algorithms are art-independent, unfortunately the service providers are not, because of the small detail that they need the total number of TPC channels, and they ask it directly to
WireReadoutart service. It is a simple change to have this parameter passed to the providers rather than discovered by the algorithm, so it should be requested if access to this database with high level interface is desired in gallery (and Python).Reviewers: