Skip to content

Fix ApplyLifetimeCorrection Var - #936

Merged
mvicenzi merged 1 commit into
SBNSoftware:errare-humanum-estfrom
carriganm95:errare-humanum-est
Nov 10, 2026
Merged

mvicenzi merged 1 commit into
SBNSoftware:errare-humanum-estfrom
carriganm95:errare-humanum-est

Conversation

@carriganm95

Copy link
Copy Markdown
Contributor

The ApplyLifetimeCorrection variable name in the fcl files has been changed (from ApplyMCLifetimeCorrection) to accurately reflect the larpandora variable. It is set to false in data/overlays and true in MC. Both data and overlays apply a lifetime correction through the drift normalization tool, this is not used in MC and the default lifetime correction should be applied in the showerNumElectronsEnergy tool.

@mvicenzi

Copilot AI balanced review requested due to automatic review settings November 10, 2026 15:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the shower-energy lifetime-correction configuration changes.

No open issues 🎉

What changed in this PR

Corrects the Stage 1 shower-energy configuration to use larpandora’s ApplyLifetimeCorrection parameter, enabling the correction for MC and disabling it for data and overlays, where drift normalization handles it.

Changes:

  • Replaces ApplyMCLifetimeCorrection with ApplyLifetimeCorrection for the shower electron-count energy tool.
  • Removes obsolete lifetime-correction settings from other shower tools.
  • Explicitly disables the shower-energy lifetime correction in overlay configuration.
File Description
fcl/​reco/​Stage1/​mc/​stage1_run2_icarus_MC.fcl Uses the corrected parameter to enable lifetime correction for MC.
fcl/​reco/​Stage1/​data/​stage1_run2_shwcal_icarus.fcl Corrects the data parameter name and removes obsolete settings.
fcl/​reco/​Definitions/​stage1_icarus_defs.fcl Updates shared shower defaults and removes obsolete settings.
fcl/​reco/​Definitions/​enable_overlay_stage1.fcl Explicitly disables lifetime correction for both cryostats’ shower-energy tools.

Review effort: Balanced

@mvicenzi mvicenzi added the private Issue or pull request about/between user branches: not aimed to the care of release managers label Nov 10, 2026
@mvicenzi

Copy link
Copy Markdown
Member

Thank you @carriganm95 !
Merging this in our working branch now.

@mvicenzi
mvicenzi merged commit 334b227 into SBNSoftware:errare-humanum-est Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

private Issue or pull request about/between user branches: not aimed to the care of release managers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants