Repository navigation
Fix ApplyLifetimeCorrection Var - #936
Merged
mvicenzi merged 1 commit intoNov 10, 2026
Merged
Conversation
…, false for data/overlays
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the shower-energy lifetime-correction configuration changes.
No open issues 🎉
What changed in this PR
Corrects the Stage 1 shower-energy configuration to use larpandora’s ApplyLifetimeCorrection parameter, enabling the correction for MC and disabling it for data and overlays, where drift normalization handles it.
Changes:
- Replaces
ApplyMCLifetimeCorrectionwithApplyLifetimeCorrectionfor the shower electron-count energy tool. - Removes obsolete lifetime-correction settings from other shower tools.
- Explicitly disables the shower-energy lifetime correction in overlay configuration.
| File | Description |
|---|---|
fcl/reco/Stage1/mc/stage1_run2_icarus_MC.fcl |
Uses the corrected parameter to enable lifetime correction for MC. |
fcl/reco/Stage1/data/stage1_run2_shwcal_icarus.fcl |
Corrects the data parameter name and removes obsolete settings. |
fcl/reco/Definitions/stage1_icarus_defs.fcl |
Updates shared shower defaults and removes obsolete settings. |
fcl/reco/Definitions/enable_overlay_stage1.fcl |
Explicitly disables lifetime correction for both cryostats’ shower-energy tools. |
Review effort: Balanced
Member
|
Thank you @carriganm95 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ApplyLifetimeCorrection variable name in the fcl files has been changed (from ApplyMCLifetimeCorrection) to accurately reflect the larpandora variable. It is set to false in data/overlays and true in MC. Both data and overlays apply a lifetime correction through the drift normalization tool, this is not used in MC and the default lifetime correction should be applied in the showerNumElectronsEnergy tool.
@mvicenzi