Repository navigation
Conversation
The constructor read the muon and pion masses with TDatabasePDG::Instance()->GetParticle(). The first GetParticle() call loads ROOT's default pdg_table.txt into the process-wide particle database. GENIE shares that database, and when it later reads its own table the entries that already exist are kept. art builds modules in alphabetical order of their labels, so in the standard CAF job pandoraTrackRange is built before systtools, and GENIE ReWeight then works with ROOT's particle properties: Delta(1232) width 0.120 GeV instead of GENIE's 0.117 GeV. CCRES and NCRES weights move by 1 to 3.5%, CCQE weights by about 1e-5, relative to the same weights computed in a process without this module. The two masses are now constants with the values the default table gave, so the range momenta do not change. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops
RangePAllPIDfrom loading ROOT's default particle table, which changes the GENIE systematic weights computed later in the same process.The bug: the
RangePAllPIDconstructor read the muon and pion masses withTDatabasePDG::Instance()->GetParticle(). The firstGetParticle()call loads ROOT's defaultpdg_table.txtinto the process-wide particle database. GENIE shares that database, and when it later reads its own table the entries that already exist are kept. art builds modules in alphabetical order of their labels, so in the standard SBND CAF jobpandoraTrackRangeis built beforesysttools, and GENIE ReWeight then works with ROOT's particle properties: for example a Delta(1232) width of 0.120 GeV instead of GENIE's 0.117 GeV.Size of the effect (SBND, sbndcode v10_26_00, BNB + cosmics): relative to the same weights computed in a process without this module, the CCRES and NCRES dials move by 1 to 3.5% of the weight for some neutrinos and the CCQE dials by about 1e-5. DIS and flux weights are not affected. The standard one-process CAF job is what production runs today.
The change: the two masses are constants, with the values the default table gave (0.105658 and 0.139570 GeV), and the
TDatabasePDGinclude is gone.Testing (library built against v10_26_00, one-process SBND CAF job on the same reco2 file, 10 events):
pandoraTrackRangeto that separate process reproduces the unfixed one-process weights exactly, which confirms the mechanism.fake_recoenergies andparent_dcy_E) shift by a few parts per million (at most 8.6e-6), because CAFMaker looks up masses in the same shared database and now sees GENIE's table.RangePAllPID_module.ccis identical in v10_26_00 and develop, so the tested file is the one in this PR. Not compiled on a develop build, and not run on ICARUS.Things to know:
TDatabasePDG::Instance()(for example CAFMaker'sFillTrueandCalorimetryAnalysis). Any of them built before the event-weight module in a job has the same effect; this PR fixes the one that is in the standard SBND CAF path.Context: found while preparing a fixed-seed comparison of the release against the menu of time, memory, and disk savings for the SBND Gen3 MC production (slides "Gen3 MC Production: Where the Time and Disk Go", Nov 2026), where the CAF stage runs as three processes and the weights disagreed with the one-process job.
🤖 Generated with Claude Code