Skip to content

Update the bunch spacing in GENIE and MeVPrtl using number measured by MicroBooNE - #419

Merged
fjnicolas merged 4 commits into
developfrom
update/BNB_bunch_spacing_GENIE
Feb 28, 2024
Merged

fjnicolas merged 4 commits into
developfrom
update/BNB_bunch_spacing_GENIE

Conversation

@VCLanNguyen

@VCLanNguyen VCLanNguyen commented Feb 27, 2024 •

Copy link
Copy Markdown
Contributor

The bunch spacing is simulated with a place holder value of 19 ns.
Update to use MicroBooNE number of 18.936 ns.
This is also consistent with SBND measured using the CRT panels in 2017-2018 with bunch spacing = 18.935 ns.
image

@VCLanNguyen VCLanNguyen changed the title Update the bunch spacing in genie_sbnd.fcl using number measured by MicroBooNE Update the bunch spacing in GENIE and MeVPrtl using number measured by MicroBooNE Feb 27, 2024
@VCLanNguyen
VCLanNguyen requested a review from rodralva February 27, 2024 16:51
@marcodeltutto

Copy link
Copy Markdown
Member

Hi @leoaliaga, @jzettle, we would like to update the time between BNB bunches in SBND. We noticed that in ICARUS this is set to 18.8313 ns:
https://github.com/SBNSoftware/icaruscode/blob/e56ae757108920268568872bbfe57dbae73baf78/icaruscode/Generators/beamspilltimings.fcl#L102

We would like to set it to 18.936 ns following MicroBooNE's paper: https://arxiv.org/abs/2304.02076

Shall ICARUS follow this change, or is there a reason for the 18.8313 ns? Thanks!

@jzettle

jzettle commented Feb 27, 2024

Copy link
Copy Markdown

@marcodeltutto I would ask @PetrilloAtWork to comment on the origin of the ICARUS BNB bunch spacing timing and the impact of making the change on the simulation (I would naively expect minimal)

@PetrilloAtWork

Copy link
Copy Markdown
Member

Considering that the simulation of bunches is mostly broken anyway (at least, the last time I checked there was no correlation between interaction time and location), it's not going to matter much. I do not see any issue with changing it.
@mvicenzi has performed measurements on ICARUS data from 2022 so he can cross-check the proposed value.

@mvicenzi

Copy link
Copy Markdown
Member

We see 18.936ns for BNB in ICARUS data as well, perfectly consistent with MicroBooNE results. No objections on my side to update the simulation settings.

@jzettle

jzettle commented Feb 27, 2024

Copy link
Copy Markdown

Just to be clear for the ICARUS collaborators who got added to this (of course reviewing is helpful) is that this PR only addresses this for SBND. We would need a corresponding PR in icaruscode or to move to a common setting in sbncode in order to make this change for ICARUS

VCLanNguyen and others added 2 commits February 27, 2024 17:46
Co-authored-by: Matteo Vicenzi <64699641+mvicenzi@users.noreply.github.com>
@marcodeltutto

Copy link
Copy Markdown
Member

Thank you @jzettle, @PetrilloAtWork, @mvicenzi!

@VCLanNguyen This issue describes the limitations @PetrilloAtWork mentioned above, in case this is relevant to your studies. SBNSoftware/sbncode#112

@VCLanNguyen

VCLanNguyen commented Feb 27, 2024 •

Copy link
Copy Markdown
Contributor Author

Thanks everyone for the comment.
From sbncode issue #12 it does not look like there will be an immediate fix to account for the time - location correlation.
So I think for now this change should make our simulation somewhat more realistic for now 😅

@PetrilloAtWork

Copy link
Copy Markdown
Member

Reviewing the code I see that it does appear that the correlation is restored, with GENIE+helper producing the time of the interaction relative to when the proton hits the target (or close to that). That is a change at least three year old, that did not get to my eyes.
Thanks to @VCLanNguyen, @rodralva and @marcodeltutto for helping me realise it.

@VCLanNguyen

Copy link
Copy Markdown
Contributor Author

trigger build

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@VCLanNguyen

Copy link
Copy Markdown
Contributor Author

@fjnicolas
The build error from the log has nothing to do with PR.
Should I merge with a tag and trigger build again?

@fjnicolas

Copy link
Copy Markdown
Contributor

@fjnicolas The build error from the log has nothing to do with PR. Should I merge with a tag and trigger build again?

@VCLanNguyen it's unrrelated and due to SBNSoftware/sbncode#388, I'll merge it after approval

@rodralva rodralva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, also great to have documented where the values come from. Thanks @VCLanNguyen !

@marcodeltutto marcodeltutto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fjnicolas
fjnicolas merged commit bb1992c into develop Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants